Bug 201067

Summary:

Web Inspector: transparency checkerboard is too bright in dark mode

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Image] Screenshot of Issue	none
Patch	none
[Image] After Patch is applied	none

Devin Rousso

Reported 2019-08-22 22:35:41 PDT

Created attachment 377102 [details] [Image] Screenshot of Issue .

Attachments
[Image] Screenshot of Issue (153.53 KB, image/png) 2019-08-22 22:35 PDT, Devin Rousso	no flags	Details
Patch (2.11 KB, patch) 2019-08-22 22:40 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
[Image] After Patch is applied (148.00 KB, image/png) 2019-08-22 22:44 PDT, Devin Rousso	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2019-08-22 22:40:35 PDT

Created attachment 377103 [details] Patch

Devin Rousso

Comment 2 2019-08-22 22:44:19 PDT

Created attachment 377104 [details] [Image] After Patch is applied I'm not sure how to "calculate" a corresponding dark mode color for a given light mode color (or pair of colors, such as the two in the checkerboard), but this looked fine to me :)

Joseph Pecoraro

Comment 3 2019-08-23 10:47:08 PDT

Comment on attachment 377103 [details] Patch r=me

WebKit Commit Bot

Comment 4 2019-08-23 11:30:05 PDT

Comment on attachment 377103 [details] Patch Clearing flags on attachment: 377103 Committed r249057: <https://trac.webkit.org/changeset/249057>

WebKit Commit Bot

Comment 5 2019-08-23 11:30:07 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 6 2019-08-23 11:31:23 PDT

<rdar://problem/54647928>

Note You need to log in before you can comment on or make changes to this bug.