Bug 201067

Summary: Web Inspector: transparency checkerboard is too bright in dark mode
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Image] Screenshot of Issue
none
Patch
none
[Image] After Patch is applied none

Description Devin Rousso 2019-08-22 22:35:41 PDT
Created attachment 377102 [details]
[Image] Screenshot of Issue

.
Comment 1 Devin Rousso 2019-08-22 22:40:35 PDT
Created attachment 377103 [details]
Patch
Comment 2 Devin Rousso 2019-08-22 22:44:19 PDT
Created attachment 377104 [details]
[Image] After Patch is applied

I'm not sure how to "calculate" a corresponding dark mode color for a given light mode color (or pair of colors, such as the two in the checkerboard), but this looked fine to me :)
Comment 3 Joseph Pecoraro 2019-08-23 10:47:08 PDT
Comment on attachment 377103 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2019-08-23 11:30:05 PDT
Comment on attachment 377103 [details]
Patch

Clearing flags on attachment: 377103

Committed r249057: <https://trac.webkit.org/changeset/249057>
Comment 5 WebKit Commit Bot 2019-08-23 11:30:07 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-08-23 11:31:23 PDT
<rdar://problem/54647928>