Bug 201067 - Web Inspector: transparency checkerboard is too bright in dark mode
Summary: Web Inspector: transparency checkerboard is too bright in dark mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-22 22:35 PDT by Devin Rousso
Modified: 2019-08-23 11:31 PDT (History)
5 users (show)

See Also:


Attachments
[Image] Screenshot of Issue (153.53 KB, image/png)
2019-08-22 22:35 PDT, Devin Rousso
no flags Details
Patch (2.11 KB, patch)
2019-08-22 22:40 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
[Image] After Patch is applied (148.00 KB, image/png)
2019-08-22 22:44 PDT, Devin Rousso
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-08-22 22:35:41 PDT
Created attachment 377102 [details]
[Image] Screenshot of Issue

.
Comment 1 Devin Rousso 2019-08-22 22:40:35 PDT
Created attachment 377103 [details]
Patch
Comment 2 Devin Rousso 2019-08-22 22:44:19 PDT
Created attachment 377104 [details]
[Image] After Patch is applied

I'm not sure how to "calculate" a corresponding dark mode color for a given light mode color (or pair of colors, such as the two in the checkerboard), but this looked fine to me :)
Comment 3 Joseph Pecoraro 2019-08-23 10:47:08 PDT
Comment on attachment 377103 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2019-08-23 11:30:05 PDT
Comment on attachment 377103 [details]
Patch

Clearing flags on attachment: 377103

Committed r249057: <https://trac.webkit.org/changeset/249057>
Comment 5 WebKit Commit Bot 2019-08-23 11:30:07 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-08-23 11:31:23 PDT
<rdar://problem/54647928>