Bug 201059

Summary:

All image drawing functions should take an argument of type ImagePaintingOptions

Product:

WebKit

Reporter:

Said Abou-Hallawa <sabouhallawa>

Component:

Images

Assignee:

Said Abou-Hallawa <sabouhallawa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, simon.fraser, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

201123

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Said Abou-Hallawa

Reported 2019-08-22 17:33:02 PDT

1) Pass ImagePaintingOptions to all the image drawing functions. Currently the top level drawing functions pass only some member of ImagePaintingOptions to lower level functions. 2) ImagePaintingOptions should be initialized with any number of the options and the order options should not matter. Currently it is hard to get the right set of constructors of ImagePaintingOptions because some callers prefers to pass few options and have the rest of options fall back to the default values.

Attachments
Patch (119.77 KB, patch) 2019-08-22 17:52 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (150.83 KB, patch) 2019-08-22 18:26 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (154.18 KB, patch) 2019-08-22 19:00 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (154.17 KB, patch) 2019-08-22 19:06 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (154.18 KB, patch) 2019-08-23 00:32 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (154.15 KB, patch) 2019-08-23 00:48 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (156.68 KB, patch) 2019-08-23 01:10 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (160.83 KB, patch) 2019-08-23 01:29 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (161.04 KB, patch) 2019-08-23 01:34 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (165.79 KB, patch) 2019-08-23 09:52 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (166.38 KB, patch) 2019-08-23 14:10 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (163.79 KB, patch) 2019-08-27 11:20 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (155.30 KB, patch) 2019-08-28 11:47 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Show Obsolete (12) View All Add attachment proposed patch, testcase, etc.