Summary: | Remove MaximalFlushInsertionPhase | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tadeu Zagallo <tzagallo> | ||||||
Component: | JavaScriptCore | Assignee: | Tadeu Zagallo <tzagallo> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer, ysuzuki | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Tadeu Zagallo
2019-08-22 08:02:41 PDT
Created attachment 377078 [details]
Patch
Comment on attachment 377078 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377078&action=review r=me Please also add the new test from Radar > Source/JavaScriptCore/ChangeLog:9 > + to remove it instead of hacking it to fix the most recent false positive. It would be good to describe the latest issue to motivate why it’s not worth keeping > JSTests/stress/set-argument-maybe-maximal-flush-should-not-extend-liveness-2.js:-1 > -//@ runDefault("--useMaximalFlushInsertionPhase=1", "--jitPolicyScale=0", "--useConcurrentJIT=0") Let’s keep these tests and just remove the option Created attachment 377163 [details]
Patch for landing
Comment on attachment 377163 [details] Patch for landing Clearing flags on attachment: 377163 Committed r249075: <https://trac.webkit.org/changeset/249075> All reviewed patches have been landed. Closing bug. Committed r249116: <https://trac.webkit.org/changeset/249116> |