Bug 201000

Summary:

run-webkit-tests: Use -noBulkSymbolication when calling spindump

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, ews-watchlist, glenn, krollin, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Jonathan Bedard

Reported 2019-08-21 15:21:57 PDT

In Catalina, we want to opt out of bulk symbolication when calling spindump, since it may prompt the user for credentials.

Attachments
Patch (5.56 KB, patch) 2019-08-21 16:34 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (5.68 KB, patch) 2019-08-22 09:56 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (5.69 KB, patch) 2019-08-22 10:18 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (3.80 KB, patch) 2019-08-27 10:14 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Jonathan Bedard

Comment 1 2019-08-21 15:22:13 PDT

<rdar://problem/53778938>

Jonathan Bedard

Comment 2 2019-08-21 16:34:46 PDT

Created attachment 376948 [details] Patch

Alexey Proskuryakov

Comment 3 2019-08-22 09:18:04 PDT

Comment on attachment 376948 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376948&action=review > Tools/Scripts/webkitpy/port/darwin.py:181 > + exit_code = host.executive.run_command(spindump_command + ['-noBulkSymbolication'], return_exit_code=True) It looks like the fallback won't be needed once macOS Catalina is the oldest supported version. Please add a comment explaining what's happening here in some reasonable detail (at least a radar link, and a FIXME to remove). That said, I'm not entirely sure which platforms we try to run this on. This is darwin.py, does that mean that this code runs on iOS?

Jonathan Bedard

Comment 4 2019-08-22 09:41:44 PDT

(In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 376948 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=376948&action=review > > > Tools/Scripts/webkitpy/port/darwin.py:181 > > + exit_code = host.executive.run_command(spindump_command + ['-noBulkSymbolication'], return_exit_code=True) > > It looks like the fallback won't be needed once macOS Catalina is the oldest > supported version. Please add a comment explaining what's happening here in > some reasonable detail (at least a radar link, and a FIXME to remove). > > That said, I'm not entirely sure which platforms we try to run this on. This > is darwin.py, does that mean that this code runs on iOS? Yes, this is run on iOS and watchOS too. Both iOS 13 and watchOS 6 have the -noSymbolication flag.

Jonathan Bedard

Comment 5 2019-08-22 09:56:23 PDT

Created attachment 377018 [details] Patch

Alexey Proskuryakov

Comment 6 2019-08-22 10:04:08 PDT

Comment on attachment 377018 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377018&action=review > Tools/Scripts/webkitpy/port/darwin.py:183 > + #FIXME: Remove when we no longer support Catalina This is not right - the time to remove is when macOS Catalina is the oldest supported version, not when we no longer support it. Please add a space after #, and a period at the end of the sentence. I'd also say "remove the fallback", not just "remove".

Jonathan Bedard

Comment 7 2019-08-22 10:18:57 PDT

Created attachment 377023 [details] Patch

WebKit Commit Bot

Comment 8 2019-08-22 12:04:58 PDT

Comment on attachment 377023 [details] Patch Clearing flags on attachment: 377023 Committed r249023: <https://trac.webkit.org/changeset/249023>

WebKit Commit Bot

Comment 9 2019-08-22 12:05:00 PDT

All reviewed patches have been landed. Closing bug.

Jonathan Bedard

Comment 10 2019-08-27 10:14:33 PDT

Reopening to attach new patch.