Summary: | [GStreamer] Hole-punch build is broken | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||
Component: | Platform | Assignee: | Philippe Normand <pnormand> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | webkit-bug-importer, ysuzuki, zan | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Philippe Normand
2019-08-21 03:17:54 PDT
Created attachment 376859 [details]
Patch
Comment on attachment 376859 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376859&action=review > Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h:72 > virtual void setVideoRectangle(const IntRect&) = 0; > - virtual ~HolePunchClient() = 0; > + virtual ~HolePunchClient() = default; Nit: the destructor should be placed first. Committed r249043: <https://trac.webkit.org/changeset/249043> |