Bug 200972

Summary: [GStreamer] Hole-punch build is broken
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer, ysuzuki, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch zan: review+

Description Philippe Normand 2019-08-21 03:17:54 PDT
I'm not landing the fix directly because I'm not sure it's the right approach.
Comment 1 Philippe Normand 2019-08-21 03:23:48 PDT
Created attachment 376859 [details]
Patch
Comment 2 Zan Dobersek 2019-08-23 03:38:11 PDT
Comment on attachment 376859 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376859&action=review

> Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h:72
>          virtual void setVideoRectangle(const IntRect&) = 0;
> -        virtual ~HolePunchClient() = 0;
> +        virtual ~HolePunchClient() = default;

Nit: the destructor should be placed first.
Comment 3 Philippe Normand 2019-08-23 03:53:18 PDT
Committed r249043: <https://trac.webkit.org/changeset/249043>
Comment 4 Radar WebKit Bug Importer 2019-08-23 03:54:19 PDT
<rdar://problem/54635405>