Bug 200965

Summary: JSTests/stress/optional-chaining should not call shouldThrowTypeError in a loop
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: Tools / TestsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Ross Kirsling
Reported 2019-08-20 20:50:03 PDT
JSTests/stress/optional-chaining should not call shouldThrowTypeError in a loop
Attachments
Patch (3.04 KB, patch)
2019-08-20 20:54 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.38 KB, patch)
2019-08-21 11:33 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2019-08-20 20:54:11 PDT
Created attachment 376842 [details] Patch
Saam Barati
Comment 2 2019-08-21 09:37:34 PDT
Comment on attachment 376842 [details] Patch Maybe run them in a shorter loop so they hit the JITs in eager tests at least? Maybe a loop with 100 iterations?
Ross Kirsling
Comment 3 2019-08-21 11:31:59 PDT
(In reply to Saam Barati from comment #2) > Comment on attachment 376842 [details] > Patch > > Maybe run them in a shorter loop so they hit the JITs in eager tests at > least? Maybe a loop with 100 iterations? Works for me.
Ross Kirsling
Comment 4 2019-08-21 11:33:19 PDT
Created attachment 376898 [details] Patch for landing
WebKit Commit Bot
Comment 5 2019-08-21 12:17:20 PDT
Comment on attachment 376898 [details] Patch for landing Clearing flags on attachment: 376898 Committed r248955: <https://trac.webkit.org/changeset/248955>
WebKit Commit Bot
Comment 6 2019-08-21 12:17:22 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-08-21 12:18:18 PDT
<rdar://problem/54566510>
Note You need to log in before you can comment on or make changes to this bug.