Bug 200961
| Summary: | [WHLSL] We can not do effects for ternary expressions and logical expressions eagerly | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> |
| Component: | WebGPU | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | dino, fpizlo, jonlee, justin_fan, mmaxfield, rmorisset, sam |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=200525 | ||
Saam Barati
We just emit before the branch for ternary and the implicit branch for logical expressions.
So if we had something like:
(b ? a[0] = 1 : a[1] = 2)
we'd store both to a[0] and a[1]
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Myles C. Maxfield
same with || and &&
Saam Barati
I believe I did this as a consequence of my removal of getters/setters/anders. We should just add tests for that in this bug.
Myles C. Maxfield
WHLSL is no longer relevant.