Bug 200942

Summary: Web Inspector: Update CodeMirror to support numeric separators in JavaScript numbers
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[IMAGE] Before
none
[IMAGE] After none

Joseph Pecoraro
Reported 2019-08-20 14:27:52 PDT
Update CodeMirror to support numeric separators in JavaScript numbers Steps to Reproduce: 1. js> 1_000 => Doesn't syntax highlight as expected Cherry-pick: [javascript mode] Support numeric separators https://github.com/codemirror/CodeMirror/commit/beab8ed123683416bfec934df73d13401ec086b5#diff-9812850bb71d31e8dd60b476abb2bae8 [javascript mode] fix tokenizing of underscore properties https://github.com/codemirror/CodeMirror/commit/463ea2c34ab442c0cae1d9732305219ca9b04dfe#diff-9812850bb71d31e8dd60b476abb2bae8
Attachments
[PATCH] Proposed Fix (2.58 KB, patch)
2019-08-20 14:28 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[IMAGE] Before (300.10 KB, image/png)
2019-08-20 14:34 PDT, Joseph Pecoraro 		no flags
Details
[IMAGE] After (300.47 KB, image/png)
2019-08-20 14:34 PDT, Joseph Pecoraro 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2019-08-20 14:28:57 PDT
Created attachment 376805 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 2 2019-08-20 14:34:41 PDT
Created attachment 376807 [details] [IMAGE] Before
Joseph Pecoraro
Comment 3 2019-08-20 14:34:52 PDT
Created attachment 376808 [details] [IMAGE] After
WebKit Commit Bot
Comment 4 2019-08-20 16:44:45 PDT
Comment on attachment 376805 [details] [PATCH] Proposed Fix Clearing flags on attachment: 376805 Committed r248922: <https://trac.webkit.org/changeset/248922>
WebKit Commit Bot
Comment 5 2019-08-20 16:44:47 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-08-20 16:45:19 PDT
<rdar://problem/54534515>
Note You need to log in before you can comment on or make changes to this bug.