Bug 200940

Summary: Web Inspector: Sources: increase the filter bar's width when it's focused if a resource type filter is active
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 200891    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
[Video] After Patch is applied none

Devin Rousso
Reported 2019-08-20 13:03:49 PDT
From <https://webkit.org/b/200891#c3>: > • I think we will want to better handle filtering at the bottom if a long name filter like "Documents" is selected. Perhaps hiding the fields when clicking into the filter field.
Attachments
Patch (17.35 KB, patch)
2019-08-20 22:20 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
[Video] After Patch is applied (282.88 KB, video/quicktime)
2019-08-20 22:20 PDT, Devin Rousso 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-08-20 22:20:20 PDT
Created attachment 376844 [details] Patch
Devin Rousso
Comment 2 2019-08-20 22:20:39 PDT
Created attachment 376845 [details] [Video] After Patch is applied
Joseph Pecoraro
Comment 3 2019-08-21 00:01:03 PDT
Comment on attachment 376844 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376844&action=review rs=me. Video looks great!! > Source/WebInspectorUI/UserInterface/Views/FilterBar.css:91 > +/* FIXME: use a different image for ::-webkit-search-decoration when :not(:placeholder-shown) */ Still needed?
Devin Rousso
Comment 4 2019-08-21 02:48:14 PDT
Comment on attachment 376844 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376844&action=review >> Source/WebInspectorUI/UserInterface/Views/FilterBar.css:91 >> +/* FIXME: use a different image for ::-webkit-search-decoration when :not(:placeholder-shown) */ > > Still needed? Yes, sadly :( There doesn't seem to be a way to access `--glyph-color-active` (which maps to `-apple-system-control-accent`) from within a SVG file, which is what we'd want given that the rest of the UI matches the system accent.
WebKit Commit Bot
Comment 5 2019-08-21 03:31:04 PDT
Comment on attachment 376844 [details] Patch Clearing flags on attachment: 376844 Committed r248940: <https://trac.webkit.org/changeset/248940>
WebKit Commit Bot
Comment 6 2019-08-21 03:31:06 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-08-21 03:32:16 PDT
<rdar://problem/54549231>
Note You need to log in before you can comment on or make changes to this bug.