Bug 200879

Summary: PendingActivationMediaStream does not need to be refcounted
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, eric.carlson, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

youenn fablet
Reported 2019-08-19 01:01:33 PDT
PendingActivationMediaStream does not need to be refcounted
Attachments
Patch (4.08 KB, patch)
2019-08-19 01:02 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (4.06 KB, patch)
2019-08-19 08:19 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (4.33 KB, patch)
2019-08-19 09:36 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.19 KB, patch)
2019-08-20 01:36 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-08-19 01:02:49 PDT
Created attachment 376673 [details] Patch
youenn fablet
Comment 2 2019-08-19 01:26:59 PDT
Will use WTF::makeUnique.
youenn fablet
Comment 3 2019-08-19 07:51:52 PDT
Comment on attachment 376673 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376673&action=review > Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:398 > + m_pendingActivationMediaStream = nullptr; No need to do this anymore sine observer handles this properly.
youenn fablet
Comment 4 2019-08-19 08:19:06 PDT
Created attachment 376686 [details] Patch
youenn fablet
Comment 5 2019-08-19 09:36:04 PDT
Created attachment 376692 [details] Patch
WebKit Commit Bot
Comment 6 2019-08-19 11:28:19 PDT
Comment on attachment 376692 [details] Patch Rejecting attachment 376692 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 376692, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog is not at the top of the file. Full output: https://webkit-queues.webkit.org/results/12941867
youenn fablet
Comment 7 2019-08-20 01:36:52 PDT
Created attachment 376752 [details] Patch for landing
WebKit Commit Bot
Comment 8 2019-08-20 02:39:31 PDT
Comment on attachment 376752 [details] Patch for landing Clearing flags on attachment: 376752 Committed r248896: <https://trac.webkit.org/changeset/248896>
WebKit Commit Bot
Comment 9 2019-08-20 02:39:33 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2019-08-20 02:40:18 PDT
<rdar://problem/54504227>
Note You need to log in before you can comment on or make changes to this bug.