| Summary: | PendingActivationMediaStream does not need to be refcounted | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | achristensen, commit-queue, eric.carlson, webkit-bug-importer, youennf | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
youenn fablet
2019-08-19 01:01:33 PDT
Created attachment 376673 [details]
Patch
Will use WTF::makeUnique. Comment on attachment 376673 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376673&action=review > Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:398 > + m_pendingActivationMediaStream = nullptr; No need to do this anymore sine observer handles this properly. Created attachment 376686 [details]
Patch
Created attachment 376692 [details]
Patch
Comment on attachment 376692 [details] Patch Rejecting attachment 376692 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 376692, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog is not at the top of the file. Full output: https://webkit-queues.webkit.org/results/12941867 Created attachment 376752 [details]
Patch for landing
Comment on attachment 376752 [details] Patch for landing Clearing flags on attachment: 376752 Committed r248896: <https://trac.webkit.org/changeset/248896> All reviewed patches have been landed. Closing bug. |