Bug 200874

Summary:

Web Inspector: Debugger: pause on assertion failures breakpoint doesn't work when inspecting a JSContext

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none

Devin Rousso

Reported 2019-08-18 19:05:02 PDT

Attachments
Patch (1.69 KB, patch) 2019-08-18 19:29 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (1.66 KB, patch) 2019-08-19 21:37 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2019-08-18 19:29:46 PDT

Created attachment 376660 [details] Patch

Joseph Pecoraro

Comment 2 2019-08-19 20:43:21 PDT

Comment on attachment 376660 [details] Patch Very nice! r=me

WebKit Commit Bot

Comment 3 2019-08-19 21:11:18 PDT Comment hidden (obsolete)

Comment on attachment 376660 [details] Patch Rejecting attachment 376660 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 376660, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=376660&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=200874&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 376660 from bug 200874. Fetching: https://bugs.webkit.org/attachment.cgi?id=376660 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Joseph Pecoraro']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/JavaScriptCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/JavaScriptCore/inspector/JSGlobalObjectConsoleClient.cpp Hunk #1 FAILED at 68. 1 out of 1 hunk FAILED -- saving rejects to file Source/JavaScriptCore/inspector/JSGlobalObjectConsoleClient.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Joseph Pecoraro']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/12944423

Devin Rousso

Comment 4 2019-08-19 21:37:04 PDT

Created attachment 376743 [details] Patch

WebKit Commit Bot

Comment 5 2019-08-19 22:19:47 PDT

Comment on attachment 376743 [details] Patch Clearing flags on attachment: 376743 Committed r248891: <https://trac.webkit.org/changeset/248891>

WebKit Commit Bot

Comment 6 2019-08-19 22:19:48 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 7 2019-08-19 22:20:17 PDT

<rdar://problem/54498932>

Note You need to log in before you can comment on or make changes to this bug.