Bug 200865

Summary: [ESNext] Support hashbang.
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: JavaScriptCoreAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Ross Kirsling
Reported 2019-08-17 17:37:04 PDT
[ESNext] Support hashbang.
Attachments
Patch (5.77 KB, patch)
2019-08-17 17:41 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.80 KB, patch)
2019-08-17 18:37 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2019-08-17 17:41:18 PDT
Created attachment 376619 [details] Patch
Mark Lam
Comment 2 2019-08-17 17:59:14 PDT
Comment on attachment 376619 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376619&action=review r=me > JSTests/stress/hashbang.js:20 > +shouldThrowSyntaxError(' #!foo'); Can you also add a case for '\n#!foo'?
Ross Kirsling
Comment 3 2019-08-17 18:37:46 PDT
Created attachment 376624 [details] Patch for landing
WebKit Commit Bot
Comment 4 2019-08-17 19:20:13 PDT
Comment on attachment 376624 [details] Patch for landing Clearing flags on attachment: 376624 Committed r248826: <https://trac.webkit.org/changeset/248826>
WebKit Commit Bot
Comment 5 2019-08-17 19:20:15 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-08-17 19:21:18 PDT
<rdar://problem/54435770>
Note You need to log in before you can comment on or make changes to this bug.