Bug 200865 - [ESNext] Support hashbang.
Summary: [ESNext] Support hashbang.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-17 17:37 PDT by Ross Kirsling
Modified: 2019-08-17 19:21 PDT (History)
8 users (show)

See Also:

Attachments
Patch (5.77 KB, patch)
2019-08-17 17:41 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Patch for landing (5.80 KB, patch)
2019-08-17 18:37 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2019-08-17 17:37:04 PDT 
[ESNext] Support hashbang.
Comment 1 Ross Kirsling 2019-08-17 17:41:18 PDT 
Created attachment 376619 [details]
Patch
Comment 2 Mark Lam 2019-08-17 17:59:14 PDT 
Comment on attachment 376619 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376619&action=review

r=me

> JSTests/stress/hashbang.js:20
> +shouldThrowSyntaxError(' #!foo');

Can you also add a case for '\n#!foo'?
Comment 3 Ross Kirsling 2019-08-17 18:37:46 PDT 
Created attachment 376624 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2019-08-17 19:20:13 PDT 
Comment on attachment 376624 [details]
Patch for landing

Clearing flags on attachment: 376624

Committed r248826: <https://trac.webkit.org/changeset/248826>
Comment 5 WebKit Commit Bot 2019-08-17 19:20:15 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-08-17 19:21:18 PDT 
<rdar://problem/54435770>