Bug 200847

Summary:

[WHLSL] Enums should be shadowed by local variables

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

WebGPU

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	saam: review+, saam: commit-queue-
Patch for committing	mmaxfield: commit-queue-
Patch for committing	none
Archive of layout-test-results from ews210 for win-future	none

Myles C. Maxfield

Reported 2019-08-16 18:56:27 PDT

...

Attachments
Patch (5.68 KB, patch) 2019-08-16 18:58 PDT, Myles C. Maxfield	saam: review+ saam: commit-queue-	Details Formatted Diff Diff
Patch for committing (5.90 KB, patch) 2019-08-16 19:35 PDT, Myles C. Maxfield	mmaxfield: commit-queue-	Details Formatted Diff Diff
Patch for committing (5.89 KB, patch) 2019-08-16 19:36 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews210 for win-future (13.44 MB, application/zip) 2019-08-16 20:51 PDT, EWS Watchlist	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Myles C. Maxfield

Comment 1 2019-08-16 18:58:13 PDT

Created attachment 376575 [details] Patch

Myles C. Maxfield

Comment 2 2019-08-16 18:58:35 PDT

https://github.com/gpuweb/WHLSL/issues/312

Saam Barati

Comment 3 2019-08-16 19:11:26 PDT

Comment on attachment 376575 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376575&action=review r=me > LayoutTests/webgpu/whlsl/structure-field-enumeration-element-clash.html:25 > + can you add a checkFail like: ``` void foo() { variable.x; } ```

Myles C. Maxfield

Comment 4 2019-08-16 19:35:21 PDT

Created attachment 376581 [details] Patch for committing

Myles C. Maxfield

Comment 5 2019-08-16 19:36:28 PDT

Created attachment 376582 [details] Patch for committing

WebKit Commit Bot

Comment 6 2019-08-16 20:03:42 PDT

Comment on attachment 376582 [details] Patch for committing Clearing flags on attachment: 376582 Committed r248812: <https://trac.webkit.org/changeset/248812>

EWS Watchlist

Comment 7 2019-08-16 20:51:09 PDT

Comment on attachment 376575 [details] Patch Attachment 376575 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12929115 New failing tests: js/error-should-not-strong-reference-global-object.html

EWS Watchlist

Comment 8 2019-08-16 20:51:11 PDT

Created attachment 376589 [details] Archive of layout-test-results from ews210 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews210 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Radar WebKit Bug Importer

Comment 9 2019-08-16 21:03:23 PDT

<rdar://problem/54419248>

Note You need to log in before you can comment on or make changes to this bug.