Bug 200829

Summary: [JSC] Promise.prototype.finally should accept non-promise objects
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, joepeck, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 200739    
Attachments:
Description Flags
Patch mark.lam: review+

Yusuke Suzuki
Reported 2019-08-16 13:34:24 PDT
[JSC] Promise.prototype.finally should accept non-promise objects
Attachments
Patch (3.35 KB, patch)
2019-08-16 13:35 PDT, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-08-16 13:35:59 PDT
Created attachment 376532 [details] Patch
Yusuke Suzuki
Comment 2 2019-08-16 13:36:53 PDT
Comment on attachment 376532 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376532&action=review > Source/JavaScriptCore/builtins/PromisePrototype.js:72 > + @throwTypeError("|this| is not a object"); We pick `a object` since the other methods are using this... We should fix it in a separate patch in a bulk manner.
Mark Lam
Comment 3 2019-08-16 13:39:41 PDT
Comment on attachment 376532 [details] Patch r=me
Yusuke Suzuki
Comment 4 2019-08-16 13:44:11 PDT
I also added a test passing `non-object` to finally to check the thrown error.
Yusuke Suzuki
Comment 5 2019-08-16 13:44:46 PDT
Committed r248793: <https://trac.webkit.org/changeset/248793>
Radar WebKit Bug Importer
Comment 6 2019-08-16 13:45:18 PDT
<rdar://problem/54405556>
Note You need to log in before you can comment on or make changes to this bug.