Bug 200818 – StorageManager does not need to subclass RefCounted

• Component: WebKit2
• Status: RESOLVED FIXED

[Chris Dumez]

StorageManager does not need to subclass RefCounted. It is owned by the StorageManagerSet and is never ref'd / deref'd.

[Chris Dumez]

Created attachment 376507 [details]
Patch

[Geoffrey Garen]

Comment on attachment 376507 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376507&action=review

r=me

> Source/WebKit/NetworkProcess/WebStorage/StorageManagerSet.cpp:69
> +                return std::make_unique<StorageManager>(WTFMove(localStorageDirectory));

Please consider using WTF::makeUnique (a new helper added yesterday).

[Chris Dumez]

(In reply to Geoffrey Garen from comment #2)
> Comment on attachment 376507 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=376507&action=review
> 
> r=me
> 
> > Source/WebKit/NetworkProcess/WebStorage/StorageManagerSet.cpp:69
> > +                return std::make_unique<StorageManager>(WTFMove(localStorageDirectory));
> 
> Please consider using WTF::makeUnique (a new helper added yesterday).

I would if it existed. The patch you're talking about does not seem to have landed.

[WebKit Commit Bot]

Comment on attachment 376507 [details]
Patch

Clearing flags on attachment: 376507

Committed r248780: <https://trac.webkit.org/changeset/248780>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/54399242>