Bug 200808

Summary: Web Inspector: rename "Invalid Characters" to "Invisible Characters" for clarity
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2019-08-15 23:52:43 PDT
In reality, an "invalid" character is just a non-printable character (a.k.a. an "invisible" character).
Attachments
Patch (5.79 KB, patch)
2019-08-15 23:54 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-08-15 23:54:14 PDT
Created attachment 376475 [details] Patch
Joseph Pecoraro
Comment 2 2019-08-16 00:46:22 PDT
Comment on attachment 376475 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376475&action=review r=me > Source/WebInspectorUI/UserInterface/Base/Setting.js:170 > - showInvalidCharacters: new WI.Setting("show-invalid-characters", false), > + showInvisibleCharacters: new WI.Setting("show-invisible-characters", !!WI.Setting.migrateValue("show-invalid-characters")), Nice!
WebKit Commit Bot
Comment 3 2019-08-16 09:54:54 PDT
Comment on attachment 376475 [details] Patch Clearing flags on attachment: 376475 Committed r248773: <https://trac.webkit.org/changeset/248773>
WebKit Commit Bot
Comment 4 2019-08-16 09:54:55 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-08-16 09:55:18 PDT
<rdar://problem/54395136>
Note You need to log in before you can comment on or make changes to this bug.