Bug 200808 - Web Inspector: rename "Invalid Characters" to "Invisible Characters" for clarity
Summary: Web Inspector: rename "Invalid Characters" to "Invisible Characters" for clarity
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-15 23:52 PDT by Devin Rousso
Modified: 2019-08-16 09:55 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.79 KB, patch)
2019-08-15 23:54 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-08-15 23:52:43 PDT 
In reality, an "invalid" character is just a non-printable character (a.k.a. an "invisible" character).
Comment 1 Devin Rousso 2019-08-15 23:54:14 PDT 
Created attachment 376475 [details]
Patch
Comment 2 Joseph Pecoraro 2019-08-16 00:46:22 PDT 
Comment on attachment 376475 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376475&action=review

r=me

> Source/WebInspectorUI/UserInterface/Base/Setting.js:170
> -    showInvalidCharacters: new WI.Setting("show-invalid-characters", false),
> +    showInvisibleCharacters: new WI.Setting("show-invisible-characters", !!WI.Setting.migrateValue("show-invalid-characters")),

Nice!
Comment 3 WebKit Commit Bot 2019-08-16 09:54:54 PDT 
Comment on attachment 376475 [details]
Patch

Clearing flags on attachment: 376475

Committed r248773: <https://trac.webkit.org/changeset/248773>
Comment 4 WebKit Commit Bot 2019-08-16 09:54:55 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-08-16 09:55:18 PDT 
<rdar://problem/54395136>