Bug 200799

Summary: [FTW] Enable CoreFoundation use if building for Apple target
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, dino, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Brent Fulgham
Reported Friday, August 16, 2019 1:04:50 AM UTC
This patch adds the last bits to get a semi-working MiniBrowser running with FTW.
Attachments
Patch (12.18 KB, patch)
2019-08-15 17:30 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 Friday, August 16, 2019 1:13:35 AM UTC
Actually, that was done previously -- this just makes it possible to use CF, which is needed for preferences.
Brent Fulgham
Comment 2 Friday, August 16, 2019 1:30:28 AM UTC
Created attachment 376449 [details] Patch
Alex Christensen
Comment 3 Friday, August 16, 2019 1:45:48 AM UTC
Comment on attachment 376449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376449&action=review > Source/cmake/OptionsFTW.cmake:218 > + find_package(LibXml2 2.9.1 REQUIRED) Isn't this just a minimum version? I think it would be fine if the minimum version were the same for apple and non-apple. > Source/cmake/OptionsFTW.cmake:-224 > - find_package(LibXslt 1.1.32 REQUIRED) ditto
Brent Fulgham
Comment 4 Friday, August 16, 2019 2:20:35 AM UTC
Comment on attachment 376449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376449&action=review >> Source/cmake/OptionsFTW.cmake:218 >> + find_package(LibXml2 2.9.1 REQUIRED) > > Isn't this just a minimum version? I think it would be fine if the minimum version were the same for apple and non-apple. The non-Apple number is what Sony is using.I wanted to keep the two distinct where our distributions are different,
WebKit Commit Bot
Comment 5 Friday, August 16, 2019 2:50:11 AM UTC
Comment on attachment 376449 [details] Patch Clearing flags on attachment: 376449 Committed r248755: <https://trac.webkit.org/changeset/248755>
WebKit Commit Bot
Comment 6 Friday, August 16, 2019 2:50:13 AM UTC
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 Friday, August 16, 2019 2:51:21 AM UTC
<rdar://problem/54373548>
Note You need to log in before you can comment on or make changes to this bug.