| Summary: | [FTW] Enable CoreFoundation use if building for Apple target | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
| Component: | WebKit2 | Assignee: | Brent Fulgham <bfulgham> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, bfulgham, commit-queue, dino, pvollan, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Brent Fulgham
2019-08-15 17:04:50 PDT
Actually, that was done previously -- this just makes it possible to use CF, which is needed for preferences. Created attachment 376449 [details]
Patch
Comment on attachment 376449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376449&action=review > Source/cmake/OptionsFTW.cmake:218 > + find_package(LibXml2 2.9.1 REQUIRED) Isn't this just a minimum version? I think it would be fine if the minimum version were the same for apple and non-apple. > Source/cmake/OptionsFTW.cmake:-224 > - find_package(LibXslt 1.1.32 REQUIRED) ditto Comment on attachment 376449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376449&action=review >> Source/cmake/OptionsFTW.cmake:218 >> + find_package(LibXml2 2.9.1 REQUIRED) > > Isn't this just a minimum version? I think it would be fine if the minimum version were the same for apple and non-apple. The non-Apple number is what Sony is using.I wanted to keep the two distinct where our distributions are different, Comment on attachment 376449 [details] Patch Clearing flags on attachment: 376449 Committed r248755: <https://trac.webkit.org/changeset/248755> All reviewed patches have been landed. Closing bug. |