Bug 200778

Summary: Yellow Lookup highlight gets stuck over Mail messages
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Tim Horton
Reported 2019-08-15 12:11:01 PDT
Yellow Lookup highlight gets stuck over Mail messages
Attachments
Patch (1.61 KB, patch)
2019-08-15 12:11 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (1.89 KB, patch)
2019-08-15 12:14 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (1.85 KB, patch)
2019-08-15 12:16 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2019-08-15 12:11:19 PDT
Created attachment 376404 [details] Patch
Tim Horton
Comment 2 2019-08-15 12:11:22 PDT
<rdar://problem/53868514>
Tim Horton
Comment 3 2019-08-15 12:14:44 PDT
Created attachment 376405 [details] Patch
Tim Horton
Comment 4 2019-08-15 12:16:41 PDT
Created attachment 376406 [details] Patch
Wenson Hsieh
Comment 5 2019-08-15 12:19:04 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 6 2019-08-15 12:22:25 PDT
(In reply to Wenson Hsieh from comment #5) > Comment on attachment 376406 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=376406&action=review > > > Source/WebKitLegacy/mac/WebView/WebView.mm:9511 > > + [weakSelf.get() _clearTextIndicatorWithAnimation:TextIndicatorWindowDismissalAnimation::FadeOut]; > > Nit - I don’t think the .get() is necessary here. Oops, never mind — I take that back :/
WebKit Commit Bot
Comment 7 2019-08-15 13:21:12 PDT
Comment on attachment 376406 [details] Patch Clearing flags on attachment: 376406 Committed r248741: <https://trac.webkit.org/changeset/248741>
WebKit Commit Bot
Comment 8 2019-08-15 13:21:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.