| Summary: | [JSC] Air does not appropriately propagate ConstFloatValue to stackmap | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 200362 | ||||||||
| Attachments: |
|
||||||||
|
Description
Yusuke Suzuki
2019-08-14 22:52:30 PDT
Created attachment 376357 [details]
Patch
Attachment 376357 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/b3/testb3_5.cpp:48: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2]
ERROR: Source/JavaScriptCore/b3/testb3_5.cpp:80: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2]
Total errors found: 2 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 376361 [details]
Patch
Attachment 376361 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/b3/testb3_5.cpp:48: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2]
ERROR: Source/JavaScriptCore/b3/testb3_5.cpp:80: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2]
Total errors found: 2 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Thanks for review! Committed r248710: <https://trac.webkit.org/changeset/248710> |