Bug 200742

Summary: [lldb-webkit] OptionSet summary shows size 0 sometimes for non-empty set
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: jer.noble, ryanhaddad, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=201056
Attachments:
Description Flags
Patch
none
To land none

Daniel Bates
Reported 2019-08-14 16:12:57 PDT
Sometimes the LLDB-pretty printed OptionSet summary for a non-empty set is 0.
Attachments
Patch (6.12 KB, patch)
2019-08-14 16:44 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
To land (7.10 KB, patch)
2019-08-22 15:05 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2019-08-14 16:44:49 PDT
Created attachment 376331 [details] Patch
Daniel Bates
Comment 2 2019-08-21 15:42:53 PDT
Comment on attachment 376331 [details] Patch Clearing flags on attachment: 376331 Committed r248970: <https://trac.webkit.org/changeset/248970>
Daniel Bates
Comment 3 2019-08-21 15:42:54 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-08-21 15:43:42 PDT
<rdar://problem/54575345>
Ryan Haddad
Comment 5 2019-08-21 17:06:48 PDT
There is a lldb_webkit_unittest test failure after this change: [1903/1912] lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFOptionSetProvider_empty failed: Traceback (most recent call last): File "/Volumes/Data/slave/mojave-release-tests-wk2/build/Tools/lldb/lldb_webkit_unittest.py", line 188, in serial_test_WTFOptionSetProvider_empty self.assertEqual(provider.get_child_at_index(0), None) AssertionError: <lldb.SBValue; proxy of <Swig Object of type 'lldb::SBValue *' at 0x1176af2a0> > != None https://build.webkit.org/builders/Apple%20Mojave%20Release%20WK2%20(Tests)/builds/6078/steps/webkitpy-test/logs/stdio
Daniel Bates
Comment 6 2019-08-21 17:19:28 PDT
Not near a computer. Roll it out and I will fix offljne
Ryan Haddad
Comment 7 2019-08-21 17:23:20 PDT
Reverted r248970 for reason: Caused lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFOptionSetProvider_empty to fail. Committed r248980: <https://trac.webkit.org/changeset/248980>
Daniel Bates
Comment 8 2019-08-21 20:35:12 PDT
Something happened to EWS. It use to run these tests.
Daniel Bates
Comment 9 2019-08-22 15:05:43 PDT
Created attachment 377058 [details] To land
Daniel Bates
Comment 10 2019-08-22 15:07:00 PDT
Comment on attachment 377058 [details] To land Clearing flags on attachment: 377058 Committed r249030: <https://trac.webkit.org/changeset/249030>
Daniel Bates
Comment 11 2019-08-22 15:07:01 PDT
All reviewed patches have been landed. Closing bug.
Daniel Bates
Comment 12 2019-08-22 15:08:34 PDT
Comment on attachment 377058 [details] To land View in context: https://bugs.webkit.org/attachment.cgi?id=377058&action=review > Tools/lldb/lldb_webkit_unittest.py:188 > - self.assertEqual(provider.get_child_at_index(0), None) > + self.assertEqual(provider.get_child_at_index(0).GetName(), 'm_storage') In retrospect, probably would be better for this to assert provider.size == 0 and should add a new test to check that the last child of the provider is always 'm_storage'.
Daniel Bates
Comment 13 2019-08-22 15:14:40 PDT
Comment on attachment 377058 [details] To land View in context: https://bugs.webkit.org/attachment.cgi?id=377058&action=review >> Tools/lldb/lldb_webkit_unittest.py:188 >> + self.assertEqual(provider.get_child_at_index(0).GetName(), 'm_storage') > > In retrospect, probably would be better for this to assert provider.size == 0 and should add a new test to check that the last child of the provider is always 'm_storage'. Filed bug #201056 for this.
Note You need to log in before you can comment on or make changes to this bug.