| Summary: | Web Inspector: there should be an opposite icon for Eye.svg when we want to hide things instead of showing them | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=17240 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Devin Rousso
2019-08-14 14:31:23 PDT
Created attachment 376311 [details]
Patch
Created attachment 376312 [details]
[Image] After Patch is applied
Comment on attachment 376311 [details]
Patch
Shouldn't such a toggle be toggling between Eye / Hide?
• Enabled has "Hide" icon => click => Disable + Show "Eye" icon
• Disabled has "Eye" icon => click => Enable + Show "Hide" icon
I like not applying the opacity filter to the status button.
> • Enabled has "Hide" icon => click => Disable + Show "Eye" icon
> • Disabled has "Eye" icon => click => Enable + Show "Hide" icon
Err, probably invert the icons I suggested. You probably want the Hide icon to show when the script is disabled, as that is the "status" of the shader. Clicking will change the status.
(In reply to Joseph Pecoraro from comment #4) > > • Enabled has "Hide" icon => click => Disable + Show "Eye" icon > > • Disabled has "Eye" icon => click => Enable + Show "Hide" icon > > Err, probably invert the icons I suggested. You probably want the Hide icon to show when the script is disabled, as that is the "status" of the shader. Clicking will change the status. My only issue with doing something like this is that if we use a simple `:hover` selector, then as soon as the user clicks to disable the shader, the "Eye" suddenly becomes a "Hide" as the `.disabled:hover` would now apply. Ideally, we'd wait till the _next_ time the user hovers over the icon to switch from "Hide.svg" to "Eye.svg". Then again, breakpoints switch immediately after the click, so maybe I'm overthinking things :P Created attachment 376509 [details]
Patch
Comment on attachment 376509 [details]
Patch
r=me
Comment on attachment 376509 [details] Patch Clearing flags on attachment: 376509 Committed r248782: <https://trac.webkit.org/changeset/248782> All reviewed patches have been landed. Closing bug. |