Bug 200721

Summary: results.webkit.org: Add content hook to FlaskRequestsResponse
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, dean_johnson, kocsen_chung, webkit-bug-importer, zhifei_fang
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=200690
Attachments:
Description Flags
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2019-08-14 09:40:28 PDT
The flask 'Response' class stores the raw bytes associated with the response as 'data'. Requests stores it as 'content'. Add a hook to the FlaskRequestsResponse class so that it conforms to the same API as requests.
Attachments
Patch (1.37 KB, patch)
2019-08-14 09:44 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.29 KB, patch)
2019-08-14 11:18 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-08-14 09:44:03 PDT
Created attachment 376274 [details] Patch
Aakash Jain
Comment 2 2019-08-14 09:46:40 PDT
Comment on attachment 376274 [details] Patch rs=me
Jonathan Bedard
Comment 3 2019-08-14 11:18:08 PDT
Created attachment 376284 [details] Patch for landing
WebKit Commit Bot
Comment 4 2019-08-15 10:35:08 PDT
Comment on attachment 376284 [details] Patch for landing Clearing flags on attachment: 376284 Committed r248727: <https://trac.webkit.org/changeset/248727>
WebKit Commit Bot
Comment 5 2019-08-15 10:35:10 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-08-15 10:36:16 PDT
<rdar://problem/54352248>
Note You need to log in before you can comment on or make changes to this bug.