Bug 200721

Summary:

results.webkit.org: Add content hook to FlaskRequestsResponse

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, commit-queue, dean_johnson, kocsen_chung, webkit-bug-importer, zhifei_fang

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=200690

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Jonathan Bedard 2019-08-14 09:40:28 PDT

The flask 'Response' class stores the raw bytes associated with the response as 'data'. Requests stores it as 'content'. Add a hook to the FlaskRequestsResponse class so that it conforms to the same API as requests.

Comment 1 Jonathan Bedard 2019-08-14 09:44:03 PDT

Created attachment 376274 [details]
Patch

Comment 2 Aakash Jain 2019-08-14 09:46:40 PDT

Comment on attachment 376274 [details]
Patch

rs=me

Comment 3 Jonathan Bedard 2019-08-14 11:18:08 PDT

Created attachment 376284 [details]
Patch for landing

Comment 4 WebKit Commit Bot 2019-08-15 10:35:08 PDT

Comment on attachment 376284 [details]
Patch for landing

Clearing flags on attachment: 376284

Committed r248727: <https://trac.webkit.org/changeset/248727>

Comment 5 WebKit Commit Bot 2019-08-15 10:35:10 PDT

All reviewed patches have been landed.  Closing bug.

Comment 6 Radar WebKit Bug Importer 2019-08-15 10:36:16 PDT

<rdar://problem/54352248>