Bug 200700

Summary: [WHLSL] Make length, clamp, operator+, operator-, operator*, operator/, operator[], operator[]=, operator.xy, operator.xy=, native
Product: WebKit Reporter: Saam Barati <saam>
Component: WebGPUAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, fpizlo, jonlee, justin_fan, mmaxfield, rmorisset, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 200699    
Attachments:
Description Flags
WIP
none
WIP
none
WIP
none
patch none

Saam Barati
Reported 2019-08-13 19:56:20 PDT
...
Attachments
WIP (144.30 KB, patch)
2019-08-13 19:58 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
WIP (62.04 KB, patch)
2019-08-13 20:12 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
WIP (100.72 KB, patch)
2019-08-13 20:29 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (118.35 KB, patch)
2019-08-14 18:45 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2019-08-13 19:58:35 PDT
Created attachment 376230 [details] WIP contains some other random stuff ATM
Saam Barati
Comment 2 2019-08-13 20:12:07 PDT
Created attachment 376232 [details] WIP
Saam Barati
Comment 3 2019-08-13 20:29:37 PDT
Created attachment 376233 [details] WIP Need to implement and add tests for "scalar <op> matrix" and "scalar <op> vector" (hopefully just tests for the latter).
Saam Barati
Comment 4 2019-08-14 18:45:56 PDT
Created attachment 376340 [details] patch
Robin Morisset
Comment 5 2019-08-14 20:22:07 PDT
Comment on attachment 376340 [details] patch I don't see where you define the new operator.xy. Otherwise it looks reasonable. It led me to discover that our semantic does not appear to match HLSL's one for scalar * vector operators. I will open a new bug about that.
Robin Morisset
Comment 6 2019-08-14 20:24:50 PDT
Comment on attachment 376340 [details] patch r=me Saam explained offline how we already had code that can support operator.xy
WebKit Commit Bot
Comment 7 2019-08-15 11:01:23 PDT
Comment on attachment 376340 [details] patch Clearing flags on attachment: 376340 Committed r248730: <https://trac.webkit.org/changeset/248730>
WebKit Commit Bot
Comment 8 2019-08-15 11:01:25 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-08-15 11:02:20 PDT
<rdar://problem/54353687>
Saam Barati
Comment 10 2019-08-15 13:14:06 PDT
debug build fix in: https://trac.webkit.org/changeset/248740/webkit
Note You need to log in before you can comment on or make changes to this bug.