Bug 200696

Summary: [WHLSL] Move Qualifiers and Semantic from VariableDeclaration to VariableDeclaration::RareData
Product: WebKit Reporter: Robin Morisset <rmorisset>
Component: WebGPUAssignee: Robin Morisset <rmorisset>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Robin Morisset
Reported 2019-08-13 17:33:50 PDT
It is super rare for variable declarations to have either a semantic or qualifiers. Yet we take 24 bytes from each and every one of them to store these. We can trivially hoist them into a separate structure, to save 16 bytes per variable declaration (from 56 to 40).
Attachments
Patch (3.15 KB, patch)
2019-08-13 17:35 PDT, Robin Morisset 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Robin Morisset
Comment 1 2019-08-13 17:35:49 PDT
Created attachment 376225 [details] Patch
WebKit Commit Bot
Comment 2 2019-08-13 18:36:32 PDT
Comment on attachment 376225 [details] Patch Clearing flags on attachment: 376225 Committed r248656: <https://trac.webkit.org/changeset/248656>
WebKit Commit Bot
Comment 3 2019-08-13 18:36:34 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-08-13 18:37:18 PDT
<rdar://problem/54283914>
Note You need to log in before you can comment on or make changes to this bug.