Bug 200649

Summary: Add a way to opt out of kern TCSM for layout tests
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, commit-queue, fpizlo, ggaren, gskachkov, guijemont, jbedard, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
set-environment-webkitpy none

Saam Barati
Reported 2019-08-12 17:02:06 PDT
...
Attachments
patch (2.04 KB, patch)
2019-08-12 19:06 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
set-environment-webkitpy (1.52 KB, patch)
2019-08-13 16:33 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2019-08-12 17:02:38 PDT
<rdar://problem/51304923>
Saam Barati
Comment 2 2019-08-12 19:06:13 PDT
Created attachment 376127 [details] patch
Alexey Proskuryakov
Comment 3 2019-08-12 20:26:43 PDT
Comment on attachment 376127 [details] patch How does one pass an option of this kind to WebKitTestRunner’s WebContent process?
Saam Barati
Comment 4 2019-08-13 15:06:02 PDT
(In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 376127 [details] > patch > > How does one pass an option of this kind to WebKitTestRunner’s WebContent > process? Set the environment variable "JSC_useKernTCSM=false"
Jonathan Bedard
Comment 5 2019-08-13 16:33:37 PDT
Created attachment 376223 [details] set-environment-webkitpy Should we be setting this webkitpy? Or in WebKitTestRunner/DumpRenderTree?
Alexey Proskuryakov
Comment 6 2019-08-13 17:10:05 PDT
> Should we be setting this webkitpy? Or in WebKitTestRunner/DumpRenderTree? I don't think that there is any practical difference. Theoretically, setting it in WebKitTestRunner/DumpRenderTree is slightly better because running them manually (without run-webkit-tests) will result in the same behavior as with run-webkit-tests. In addition to layout tests, JSC tests probably need this too. Also, we should probably use a separate bug for the adoption.
WebKit Commit Bot
Comment 7 2019-08-13 20:38:13 PDT
Comment on attachment 376127 [details] patch Clearing flags on attachment: 376127 Committed r248661: <https://trac.webkit.org/changeset/248661>
WebKit Commit Bot
Comment 8 2019-08-13 20:38:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.