Bug 200639

Summary: Web Inspector: REGRESSION: DOMDebugger: breakpoints are forcibly enabled when resolving DOM breakpoints for newly added nodes
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Devin Rousso 2019-08-12 11:54:26 PDT 
# STEPS TO REPRODUCE:
1. inspect any page
2. set a DOM breakpoint
3. disable breakpoints
4. reload the page
 => breakpoints enabled

Since DOM breakpoints revolve around a given DOM node, we attempt to restore those breakpoints whenever new nodes are added by matching them to the path of the DOM breakpoint.  When doing so, we should be in a "temporarily restoring breakpoints" mode so that we don't forcibly enable all breakpoints.
Comment 1 Devin Rousso 2019-08-12 11:59:58 PDT 
Created attachment 376084 [details]
Patch
Comment 2 Joseph Pecoraro 2019-08-12 20:42:14 PDT 
Comment on attachment 376084 [details]
Patch

rs=me
Comment 3 WebKit Commit Bot 2019-08-12 20:50:47 PDT 
Comment on attachment 376084 [details]
Patch

Clearing flags on attachment: 376084

Committed r248587: <https://trac.webkit.org/changeset/248587>
Comment 4 WebKit Commit Bot 2019-08-12 20:50:48 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-08-12 20:51:17 PDT 
<rdar://problem/54240350>