Bug 200639 - Web Inspector: REGRESSION: DOMDebugger: breakpoints are forcibly enabled when resolving DOM breakpoints for newly added nodes
Summary: Web Inspector: REGRESSION: DOMDebugger: breakpoints are forcibly enabled when...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-12 11:54 PDT by Devin Rousso
Modified: 2019-08-12 20:51 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.44 KB, patch)
2019-08-12 11:59 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-08-12 11:54:26 PDT 
# STEPS TO REPRODUCE:
1. inspect any page
2. set a DOM breakpoint
3. disable breakpoints
4. reload the page
 => breakpoints enabled

Since DOM breakpoints revolve around a given DOM node, we attempt to restore those breakpoints whenever new nodes are added by matching them to the path of the DOM breakpoint.  When doing so, we should be in a "temporarily restoring breakpoints" mode so that we don't forcibly enable all breakpoints.
Comment 1 Devin Rousso 2019-08-12 11:59:58 PDT 
Created attachment 376084 [details]
Patch
Comment 2 Joseph Pecoraro 2019-08-12 20:42:14 PDT 
Comment on attachment 376084 [details]
Patch

rs=me
Comment 3 WebKit Commit Bot 2019-08-12 20:50:47 PDT 
Comment on attachment 376084 [details]
Patch

Clearing flags on attachment: 376084

Committed r248587: <https://trac.webkit.org/changeset/248587>
Comment 4 WebKit Commit Bot 2019-08-12 20:50:48 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-08-12 20:51:17 PDT 
<rdar://problem/54240350>