| Summary: | [GStreamer] Deal with slow buffer consumption in GStreamerMediaStreamSource | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Thibault Saunier <tsaunier> | ||||
| Component: | New Bugs | Assignee: | Thibault Saunier <tsaunier> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, pnormand, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Thibault Saunier
2019-08-12 10:43:09 PDT
Created attachment 376077 [details]
Patch
Comment on attachment 376077 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376077&action=review > Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:553 > static gboolean webkitMediaStreamSrcSetupAppSrc(WebKitMediaStreamSrc* self, > - MediaStreamTrackPrivate* track, GstElement** element, > + MediaStreamTrackPrivate* track, WebKitMediaStreamSrc::SourceData* data, > GstStaticPadTemplate* pad_template, bool onlyTrack) Where's the call site for this? I don't see it updated in this patch? Comment on attachment 376077 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376077&action=review >> Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:553 >> GstStaticPadTemplate* pad_template, bool onlyTrack) > > Where's the call site for this? I don't see it updated in this patch? In `webkitMediaStreamSrcAddTrack` - no need to update it here as it does: > res = webkitMediaStreamSrcSetupAppSrc(self, track, &self->audioSrc, &audioSrcTemplate, onlyTrack); and `self->audioSrc` has been changed to `WebKitMediaStreamSrc::SourceData`. Comment on attachment 376077 [details] Patch Clearing flags on attachment: 376077 Committed r248721: <https://trac.webkit.org/changeset/248721> All reviewed patches have been landed. Closing bug. |