Bug 200630

Summary: Remove an assertion in ~StorageArea()
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, cdumez, commit-queue, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Sihui Liu
Reported 2019-08-12 10:25:10 PDT
In https://bugs.webkit.org/show_bug.cgi?id=199713, we clear the LocalStorageNamespace before the destructor of LocalStorageNamespace is invoked, to make sure StorageArea gets destroyed on the background thread. StorageArea can get destroyed before LocalStorageNamespace, so the ASSERT(!m_localStorageNamespace) in ~StorageArea() is not true any more.
Attachments
Patch (1.56 KB, patch)
2019-08-12 10:29 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2019-08-12 10:28:09 PDT
<rdar://problem/54097722>
Sihui Liu
Comment 2 2019-08-12 10:29:27 PDT
Created attachment 376074 [details] Patch
WebKit Commit Bot
Comment 3 2019-08-12 12:33:59 PDT
Comment on attachment 376074 [details] Patch Clearing flags on attachment: 376074 Committed r248542: <https://trac.webkit.org/changeset/248542>
WebKit Commit Bot
Comment 4 2019-08-12 12:34:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.