Bug 200630

Summary: Remove an assertion in ~StorageArea()
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, cdumez, commit-queue, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Sihui Liu 2019-08-12 10:25:10 PDT 
In https://bugs.webkit.org/show_bug.cgi?id=199713, we clear the LocalStorageNamespace before the destructor of LocalStorageNamespace is invoked, to make sure StorageArea gets destroyed on the background thread. 
StorageArea can get destroyed before LocalStorageNamespace, so the ASSERT(!m_localStorageNamespace) in ~StorageArea() is not true any more.
Comment 1 Sihui Liu 2019-08-12 10:28:09 PDT 
<rdar://problem/54097722>
Comment 2 Sihui Liu 2019-08-12 10:29:27 PDT 
Created attachment 376074 [details]
Patch
Comment 3 WebKit Commit Bot 2019-08-12 12:33:59 PDT 
Comment on attachment 376074 [details]
Patch

Clearing flags on attachment: 376074

Committed r248542: <https://trac.webkit.org/changeset/248542>
Comment 4 WebKit Commit Bot 2019-08-12 12:34:01 PDT 
All reviewed patches have been landed.  Closing bug.