Bug 200630 - Remove an assertion in ~StorageArea()
Summary: Remove an assertion in ~StorageArea()
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
Keywords: InRadar
Depends on:
Reported: 2019-08-12 10:25 PDT by Sihui Liu
Modified: 2019-08-12 12:34 PDT (History)
6 users (show)

See Also:

Patch (1.56 KB, patch)
2019-08-12 10:29 PDT, Sihui Liu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2019-08-12 10:25:10 PDT
In https://bugs.webkit.org/show_bug.cgi?id=199713, we clear the LocalStorageNamespace before the destructor of LocalStorageNamespace is invoked, to make sure StorageArea gets destroyed on the background thread. 
StorageArea can get destroyed before LocalStorageNamespace, so the ASSERT(!m_localStorageNamespace) in ~StorageArea() is not true any more.
Comment 1 Sihui Liu 2019-08-12 10:28:09 PDT
Comment 2 Sihui Liu 2019-08-12 10:29:27 PDT
Created attachment 376074 [details]
Comment 3 WebKit Commit Bot 2019-08-12 12:33:59 PDT
Comment on attachment 376074 [details]

Clearing flags on attachment: 376074

Committed r248542: <https://trac.webkit.org/changeset/248542>
Comment 4 WebKit Commit Bot 2019-08-12 12:34:01 PDT
All reviewed patches have been landed.  Closing bug.