Bug 200622

Summary: [MSE][GStreamer] Don't use vorbisparse
Product: WebKit Reporter: Alicia Boya García <aboya>
Component: WebKitGTKAssignee: Alicia Boya García <aboya>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, commit-queue, pnormand
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alicia Boya García
Reported 2019-08-11 08:01:58 PDT
This patch has been splitted from the original WebKitMediaSrc rework patch (https://bugs.webkit.org/show_bug.cgi?id=199719). Unlike other parsers, vorbisparse has latency (in the sense that when it gets a chain call with a series of complete frames, it may not emit the parsed frames until another chain in the future), which makes it inappropriate for AppendPipeline, as there is no good way I know to flush it. But actually vorbisparse is not known to be necessary and it was only introduced for consistency with other formats. Parsers are used in AppendPipeline to reconstruct information that is lost due to poor muxes. There have been no reported cases of this being a problem with Vorbis in WebM, so I'm just removing the parser. Fixes imported/w3c/web-platform-tests/media-source/mediasource-config-change-webm-a-bitrate.html
Attachments
Patch (4.29 KB, patch)
2019-08-11 08:03 PDT, Alicia Boya García 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alicia Boya García
Comment 1 2019-08-11 08:03:06 PDT
Created attachment 376042 [details] Patch
WebKit Commit Bot
Comment 2 2019-08-11 09:21:31 PDT
Comment on attachment 376042 [details] Patch Clearing flags on attachment: 376042 Committed r248521: <https://trac.webkit.org/changeset/248521>
WebKit Commit Bot
Comment 3 2019-08-11 09:21:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.