Summary: | [WTF] Add makeUnique<T>, which ensures T is fast-allocated | ||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||||||||||||||||||||||||||||||||||||||||||||
Component: | Web Template Framework | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||||||||||||||||||||||||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||||||||||||||||||||||||||
Severity: | Normal | CC: | achristensen, benjamin, cdumez, cmarcelo, darin, dbates, ews-watchlist, galpeter, ggaren, saam, webkit-bug-importer | ||||||||||||||||||||||||||||||||||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||||||||||||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||||||||||||||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||||||||||||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||||||||||||||||||||||||||||||||
Bug Depends on: | 200611 | ||||||||||||||||||||||||||||||||||||||||||||||||||||
Bug Blocks: | 200878 | ||||||||||||||||||||||||||||||||||||||||||||||||||||
Attachments: |
|
Description
Yusuke Suzuki
2019-08-10 19:42:13 PDT
I tried and it finds many classes / structs that are not allocated from FastMalloc. It is worth doing. Created attachment 376144 [details]
Patch
Attachment 376144 [details] did not pass style-queue:
ERROR: Source/WebCore/page/UserContentController.cpp:76: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/page/UserContentController.cpp:103: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:97: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebCore/layout/layouttree/LayoutBox.cpp:426: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/FastMalloc.h:304: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WTF/wtf/FastMalloc.h:310: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:566: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:571: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:608: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/bmalloc/bmalloc/IsoHeap.h:85: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/dom/KeyboardEvent.cpp:99: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:977: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:978: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:984: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:985: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderObject.cpp:1896: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/bmalloc/bmalloc/IsoHeapInlines.h:126: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:90: Extra space before ( in function call [whitespace/parens] [4]
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp"
ERROR: Source/WebCore/platform/audio/DenormalDisabler.h:44: Failed to find complete declaration of class DenormalDisabler [build/class] [5]
ERROR: Source/WebCore/page/Page.cpp:273: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
Total errors found: 22 in 1242 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 376145 [details]
Patch
Attachment 376145 [details] did not pass style-queue:
ERROR: Source/WebCore/page/UserContentController.cpp:76: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/page/UserContentController.cpp:103: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:97: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebCore/layout/layouttree/LayoutBox.cpp:426: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/FastMalloc.h:304: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WTF/wtf/FastMalloc.h:310: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:566: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:571: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:608: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/bmalloc/bmalloc/IsoHeap.h:85: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/dom/KeyboardEvent.cpp:99: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:977: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:978: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:984: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:985: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderObject.cpp:1896: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/bmalloc/bmalloc/IsoHeapInlines.h:126: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:90: Extra space before ( in function call [whitespace/parens] [4]
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp"
ERROR: Source/WebCore/platform/audio/DenormalDisabler.h:44: Failed to find complete declaration of class DenormalDisabler [build/class] [5]
ERROR: Source/WebCore/page/Page.cpp:273: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
Total errors found: 22 in 1242 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 376147 [details]
Patch
Attachment 376147 [details] did not pass style-queue:
ERROR: Source/WebCore/page/UserContentController.cpp:76: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/page/UserContentController.cpp:103: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:97: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebCore/layout/layouttree/LayoutBox.cpp:426: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/FastMalloc.h:304: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WTF/wtf/FastMalloc.h:310: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:566: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:571: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:608: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/bmalloc/bmalloc/IsoHeap.h:85: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/dom/KeyboardEvent.cpp:99: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:977: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:978: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:984: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:985: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderObject.cpp:1896: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/bmalloc/bmalloc/IsoHeapInlines.h:126: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:90: Extra space before ( in function call [whitespace/parens] [4]
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp"
ERROR: Source/WebCore/platform/audio/DenormalDisabler.h:44: Failed to find complete declaration of class DenormalDisabler [build/class] [5]
ERROR: Source/WebCore/page/Page.cpp:273: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
Total errors found: 22 in 1244 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 376151 [details]
Patch
Created attachment 376153 [details]
Patch
Attachment 376153 [details] did not pass style-queue:
ERROR: Source/WebCore/page/UserContentController.cpp:76: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/page/UserContentController.cpp:103: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:97: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebCore/layout/layouttree/LayoutBox.cpp:426: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/FastMalloc.h:304: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WTF/wtf/FastMalloc.h:310: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:566: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:571: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:608: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/bmalloc/bmalloc/IsoHeap.h:85: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/dom/KeyboardEvent.cpp:99: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:977: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:978: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:984: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:985: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderObject.cpp:1896: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/bmalloc/bmalloc/IsoHeapInlines.h:126: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:90: Extra space before ( in function call [whitespace/parens] [4]
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp"
ERROR: Source/WebCore/platform/audio/DenormalDisabler.h:44: Failed to find complete declaration of class DenormalDisabler [build/class] [5]
ERROR: Source/WebCore/page/Page.cpp:273: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
Total errors found: 22 in 1246 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 376154 [details]
Patch
Attachment 376154 [details] did not pass style-queue:
ERROR: Source/WebCore/page/UserContentController.cpp:76: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/page/UserContentController.cpp:103: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:97: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebCore/layout/layouttree/LayoutBox.cpp:426: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/FastMalloc.h:304: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WTF/wtf/FastMalloc.h:310: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:566: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:571: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:608: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/bmalloc/bmalloc/IsoHeap.h:85: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/dom/KeyboardEvent.cpp:99: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:977: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:978: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:984: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:985: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderObject.cpp:1896: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/bmalloc/bmalloc/IsoHeapInlines.h:126: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:90: Extra space before ( in function call [whitespace/parens] [4]
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp"
ERROR: Source/WebCore/platform/audio/DenormalDisabler.h:44: Failed to find complete declaration of class DenormalDisabler [build/class] [5]
ERROR: Source/WebCore/page/Page.cpp:273: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
Total errors found: 22 in 1251 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 376156 [details]
Patch
Created attachment 376157 [details]
Patch
Attachment 376157 [details] did not pass style-queue:
ERROR: Source/WebCore/page/UserContentController.cpp:76: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/page/UserContentController.cpp:103: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:97: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebCore/layout/layouttree/LayoutBox.cpp:426: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/FastMalloc.h:304: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WTF/wtf/FastMalloc.h:310: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:566: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:571: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:608: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/bmalloc/bmalloc/IsoHeap.h:85: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/dom/KeyboardEvent.cpp:99: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:977: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:978: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:984: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:985: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderObject.cpp:1896: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/bmalloc/bmalloc/IsoHeapInlines.h:126: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:90: Extra space before ( in function call [whitespace/parens] [4]
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp"
ERROR: Source/WebCore/platform/audio/DenormalDisabler.h:44: Failed to find complete declaration of class DenormalDisabler [build/class] [5]
ERROR: Source/WebCore/page/Page.cpp:273: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
Total errors found: 22 in 1286 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 376192 [details]
Patch
Attachment 376192 [details] did not pass style-queue:
ERROR: Source/WebCore/page/UserContentController.cpp:76: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/page/UserContentController.cpp:103: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:97: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebCore/layout/layouttree/LayoutBox.cpp:450: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/FastMalloc.h:304: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WTF/wtf/FastMalloc.h:310: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:566: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:571: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:608: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/bmalloc/bmalloc/IsoHeap.h:85: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/dom/KeyboardEvent.cpp:99: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:977: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:978: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:984: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:985: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderObject.cpp:1896: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/bmalloc/bmalloc/IsoHeapInlines.h:126: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:90: Extra space before ( in function call [whitespace/parens] [4]
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp"
ERROR: Source/WebCore/platform/audio/DenormalDisabler.h:44: Failed to find complete declaration of class DenormalDisabler [build/class] [5]
ERROR: Source/WebCore/page/Page.cpp:273: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
Total errors found: 22 in 1288 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 376323 [details]
Patch
Attachment 376323 [details] did not pass style-queue:
ERROR: Source/WebCore/page/UserContentController.cpp:76: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/page/UserContentController.cpp:103: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:97: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebCore/layout/layouttree/LayoutBox.cpp:450: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/FastMalloc.h:304: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WTF/wtf/FastMalloc.h:310: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:566: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:571: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:608: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/bmalloc/bmalloc/IsoHeap.h:85: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/dom/KeyboardEvent.cpp:99: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:977: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:978: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:984: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:985: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderObject.cpp:1896: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/bmalloc/bmalloc/IsoHeapInlines.h:126: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:90: Extra space before ( in function call [whitespace/parens] [4]
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp"
ERROR: Source/WebCore/platform/audio/DenormalDisabler.h:44: Failed to find complete declaration of class DenormalDisabler [build/class] [5]
ERROR: Source/WebCore/page/Page.cpp:273: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
Total errors found: 22 in 1309 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 376337 [details]
Patch
Created attachment 376339 [details]
Patch
Attachment 376339 [details] did not pass style-queue:
ERROR: Source/WebCore/page/UserContentController.cpp:76: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/page/UserContentController.cpp:103: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:97: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebCore/layout/layouttree/LayoutBox.cpp:450: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/FastMalloc.h:304: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WTF/wtf/FastMalloc.h:310: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:566: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:571: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:608: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/bmalloc/bmalloc/IsoHeap.h:85: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/dom/KeyboardEvent.cpp:99: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:977: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:978: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:984: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:985: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderObject.cpp:1896: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/bmalloc/bmalloc/IsoHeapInlines.h:126: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:90: Extra space before ( in function call [whitespace/parens] [4]
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp"
ERROR: Source/WebCore/platform/audio/DenormalDisabler.h:44: Failed to find complete declaration of class DenormalDisabler [build/class] [5]
ERROR: Source/WebCore/page/Page.cpp:273: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
Total errors found: 22 in 1312 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 376351 [details]
Patch
Attachment 376351 [details] did not pass style-queue:
ERROR: Source/WebCore/page/UserContentController.cpp:76: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/page/UserContentController.cpp:103: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:97: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebCore/layout/layouttree/LayoutBox.cpp:450: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/FastMalloc.h:304: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WTF/wtf/FastMalloc.h:310: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:566: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:571: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:608: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/bmalloc/bmalloc/IsoHeap.h:85: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/dom/KeyboardEvent.cpp:99: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:977: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:978: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:984: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:985: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderObject.cpp:1896: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/bmalloc/bmalloc/IsoHeapInlines.h:126: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:90: Extra space before ( in function call [whitespace/parens] [4]
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp"
ERROR: Source/WebCore/platform/audio/DenormalDisabler.h:44: Failed to find complete declaration of class DenormalDisabler [build/class] [5]
ERROR: Source/WebCore/page/Page.cpp:273: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
Total errors found: 22 in 1315 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 376360 [details]
Patch
Created attachment 376362 [details]
Patch
Attachment 376362 [details] did not pass style-queue:
ERROR: Source/WebCore/page/UserContentController.cpp:76: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/page/UserContentController.cpp:103: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:97: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebCore/layout/layouttree/LayoutBox.cpp:450: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/FastMalloc.h:304: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WTF/wtf/FastMalloc.h:310: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:566: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:571: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:608: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/bmalloc/bmalloc/IsoHeap.h:85: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/dom/KeyboardEvent.cpp:99: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:977: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:978: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:984: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:985: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderObject.cpp:1896: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/bmalloc/bmalloc/IsoHeapInlines.h:126: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:90: Extra space before ( in function call [whitespace/parens] [4]
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp"
ERROR: Source/WebCore/platform/audio/DenormalDisabler.h:44: Failed to find complete declaration of class DenormalDisabler [build/class] [5]
ERROR: Source/WebCore/page/Page.cpp:273: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
Total errors found: 22 in 1327 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 376365 [details]
Patch
Attachment 376365 [details] did not pass style-queue:
ERROR: Source/WebCore/page/UserContentController.cpp:76: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/page/UserContentController.cpp:103: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:97: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebCore/layout/layouttree/LayoutBox.cpp:450: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/FastMalloc.h:304: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WTF/wtf/FastMalloc.h:310: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:566: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:571: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:608: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/bmalloc/bmalloc/IsoHeap.h:85: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/dom/KeyboardEvent.cpp:99: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:977: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:978: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:984: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:985: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderObject.cpp:1896: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/bmalloc/bmalloc/IsoHeapInlines.h:126: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:90: Extra space before ( in function call [whitespace/parens] [4]
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp"
ERROR: Source/WebCore/platform/audio/DenormalDisabler.h:44: Failed to find complete declaration of class DenormalDisabler [build/class] [5]
ERROR: Source/WebCore/page/Page.cpp:273: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
Total errors found: 22 in 1329 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 376368 [details]
Patch
Attachment 376368 [details] did not pass style-queue:
ERROR: Source/WebCore/page/UserContentController.cpp:76: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/page/UserContentController.cpp:103: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:97: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebCore/layout/layouttree/LayoutBox.cpp:450: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/FastMalloc.h:304: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WTF/wtf/FastMalloc.h:310: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:566: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:571: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:608: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/bmalloc/bmalloc/IsoHeap.h:85: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/dom/KeyboardEvent.cpp:99: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:977: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:978: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:984: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:985: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderObject.cpp:1896: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/bmalloc/bmalloc/IsoHeapInlines.h:126: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:90: Extra space before ( in function call [whitespace/parens] [4]
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp"
ERROR: Source/WebCore/platform/audio/DenormalDisabler.h:44: Failed to find complete declaration of class DenormalDisabler [build/class] [5]
ERROR: Source/WebCore/page/Page.cpp:273: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
Total errors found: 22 in 1331 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 376368 [details] Patch Attachment 376368 [details] did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/12916839 New failing tests: mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-llint Created attachment 376417 [details]
Patch
Attachment 376417 [details] did not pass style-queue:
ERROR: Source/WebCore/page/UserContentController.cpp:76: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/page/UserContentController.cpp:103: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:97: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebCore/layout/layouttree/LayoutBox.cpp:450: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WTF/wtf/FastMalloc.h:304: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WTF/wtf/FastMalloc.h:310: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:566: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:571: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:608: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/bmalloc/bmalloc/IsoHeap.h:85: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/dom/KeyboardEvent.cpp:99: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:977: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:978: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:984: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:985: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderObject.cpp:1896: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/bmalloc/bmalloc/IsoHeapInlines.h:126: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:90: Extra space before ( in function call [whitespace/parens] [4]
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp"
ERROR: Source/WebCore/platform/audio/DenormalDisabler.h:44: Failed to find complete declaration of class DenormalDisabler [build/class] [5]
ERROR: Source/WebCore/page/Page.cpp:273: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
Total errors found: 22 in 1331 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 376417 [details]
Patch
r=me
Looks like this caught lots of optimization opportunities without adding undue complexity. Nice!
Might be worth emailing webkit-dev to share this change in style.
Probably good to let EWS finish before landing.
Comment on attachment 376417 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376417&action=review There’s another way to stage this. A) Add WTF_MAKE_FAST_ALLOCATED because of things that we learned from making this change locally. B) Change callers from std::make_unique to WTF::makeUnique. C) Add the checking that makes it a compilation failure to use makeUnique without WTF_MAKE_FAST_ALLOCATED. What I like about this staging is that each patch is safe on its own, and can even be broken into multiple smaller pieces if needed. And patch C is small and easy to roll in and out. You can do it in the order A, B, C, or B, A, C, or any order as long as it culminates in C. > Source/WTF/wtf/FastMalloc.h:304 > +typedef int __fastAllocatedClass; \ Since this is new code, why not "using" instead of "typedef"? Let's not use "double underscore", which is reserved in the language; many other patterns are not reserved. > Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDM.h:54 > -class LegacyCDM { > +class LegacyCDM final { > + WTF_MAKE_FAST_ALLOCATED; One technique I have used in the past is to land all these changes separately first. Then Comment on attachment 376417 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376417&action=review Doing it all at once is probably OK too. Just harder to roll out if there’s a problem. I guess there’s also: D) Add a check-webkit-style verifier to complain if we use std::make_unique. E) Do some trick to make it a compiler error if we accidentally use std::make_unique. >> Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDM.h:54 >> + WTF_MAKE_FAST_ALLOCATED; > > One technique I have used in the past is to land all these changes separately first. Then I was just pointing out that this could be part of a patch (A) that I mentioned. Comment on attachment 376417 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376417&action=review > Source/WTF/benchmarks/LockFairnessTest.cpp:64 > + std::unique_ptr<unsigned[]> counts = makeUniqueWithoutFastMallocCheck<unsigned[]>(numThreads); Isn't this what makeUniqueArray is for? (In reply to Darin Adler from comment #36) > Comment on attachment 376417 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=376417&action=review > > There’s another way to stage this. > > A) Add WTF_MAKE_FAST_ALLOCATED because of things that we learned from making > this change locally. > > B) Change callers from std::make_unique to WTF::makeUnique. > > C) Add the checking that makes it a compilation failure to use makeUnique > without WTF_MAKE_FAST_ALLOCATED. > > What I like about this staging is that each patch is safe on its own, and > can even be broken into multiple smaller pieces if needed. And patch C is > small and easy to roll in and out. > > You can do it in the order A, B, C, or B, A, C, or any order as long as it > culminates in C. This sounds nice! I'll mechanically split this patch into these pieces and land them separately for roll-out ease. > > > Source/WTF/wtf/FastMalloc.h:304 > > +typedef int __fastAllocatedClass; \ > > Since this is new code, why not "using" instead of "typedef"? Nice, fixed. > > Let's not use "double underscore", which is reserved in the language; many > other patterns are not reserved. I'll use very long word instead, like, `webkitFastAllocatedClass` etc. > > > Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDM.h:54 > > -class LegacyCDM { > > +class LegacyCDM final { > > + WTF_MAKE_FAST_ALLOCATED; > > One technique I have used in the past is to land all these changes > separately first. Then (In reply to Darin Adler from comment #37) > Comment on attachment 376417 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=376417&action=review > > Doing it all at once is probably OK too. Just harder to roll out if there’s > a problem. > > I guess there’s also: > > D) Add a check-webkit-style verifier to complain if we use std::make_unique. While I'll land separate three patches as A-C in this bug, I'll create a patch for D and upload it to a separate bug for review :) > > E) Do some trick to make it a compiler error if we accidentally use > std::make_unique. ThirdParty code (libwebrtc etc.) is still using std::make_unique, and the header having std::make_unique can be included in WebKit project, so maybe, it is difficult. > > >> Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDM.h:54 > >> + WTF_MAKE_FAST_ALLOCATED; > > > > One technique I have used in the past is to land all these changes separately first. Then > > I was just pointing out that this could be part of a patch (A) that I > mentioned. (In reply to Alex Christensen from comment #38) > Comment on attachment 376417 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=376417&action=review > > > Source/WTF/benchmarks/LockFairnessTest.cpp:64 > > + std::unique_ptr<unsigned[]> counts = makeUniqueWithoutFastMallocCheck<unsigned[]>(numThreads); > > Isn't this what makeUniqueArray is for? Right. Fixed :) Created attachment 376470 [details]
A: Annotation Patch
Attachment 376470 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/audio/DenormalDisabler.h:44: Failed to find complete declaration of class DenormalDisabler [build/class] [5]
Total errors found: 1 in 405 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Tested iOS locally. Committed r248762: <https://trac.webkit.org/changeset/248762> (In reply to Yusuke Suzuki from comment #43) > Committed r248762: <https://trac.webkit.org/changeset/248762> "A" patch goes. I'll upload the "B" patch, and land it tomorrow. And after that, I'll land "C" patch. Then, announcing makeUnique in webkit-dev and open a new bug for "D" patch. (In reply to Yusuke Suzuki from comment #45) > (In reply to Yusuke Suzuki from comment #43) > > Committed r248762: <https://trac.webkit.org/changeset/248762> > > "A" patch goes. I'll upload the "B" patch, and land it tomorrow. And after > that, I'll land "C" patch. Then, announcing makeUnique in webkit-dev and > open a new bug for "D" patch. One of the good thing this patch found is that we missed this annotation even in recent code, like Source/WebCore/layout/inlineformatting/InlineItem.h. After introducing makeUnique, we no longer have this! Reopening to attach new patch. Created attachment 376485 [details]
B: makeUnique / makeUniqueWithoutFastMallocCheck
Created attachment 376486 [details]
B: makeUnique / makeUniqueWithoutFastMallocCheck
Attachment 376486 [details] did not pass style-queue:
ERROR: Source/WebCore/page/UserContentController.cpp:76: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/page/UserContentController.cpp:103: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:97: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebCore/layout/layouttree/LayoutBox.cpp:450: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:566: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:571: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:608: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/dom/KeyboardEvent.cpp:99: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:977: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:978: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:984: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:985: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderObject.cpp:1896: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:90: Extra space before ( in function call [whitespace/parens] [4]
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp"
ERROR: Source/WebCore/page/Page.cpp:273: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
Total errors found: 17 in 1018 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to Alex Christensen from comment #38) > Comment on attachment 376417 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=376417&action=review > > > Source/WTF/benchmarks/LockFairnessTest.cpp:64 > > + std::unique_ptr<unsigned[]> counts = makeUniqueWithoutFastMallocCheck<unsigned[]>(numThreads); > > Isn't this what makeUniqueArray is for? Unfortunately, it seems that some of TestWebKit headers (maybe?) things are compiled without bmalloc, so we cannot use makeUniqueArray :( Created attachment 376665 [details]
B: makeUnique / makeUniqueWithoutFastMallocCheck
Attachment 376665 [details] did not pass style-queue:
ERROR: Source/WebCore/page/UserContentController.cpp:76: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/page/UserContentController.cpp:103: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:97: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebCore/layout/layouttree/LayoutBox.cpp:450: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:566: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:571: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:608: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/dom/KeyboardEvent.cpp:99: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:977: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:978: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:984: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:985: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderObject.cpp:1896: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:90: Extra space before ( in function call [whitespace/parens] [4]
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp"
ERROR: Source/WebCore/page/Page.cpp:273: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
Total errors found: 17 in 1024 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r248846: <https://trac.webkit.org/changeset/248846> Reopening to attach new patch. Created attachment 376666 [details]
C: makeUnique should perform static-assert
Created attachment 376672 [details]
C: makeUnique should perform static-assert
Comment on attachment 376665 [details] B: makeUnique / makeUniqueWithoutFastMallocCheck Attachment 376665 [details] did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/12939317 New failing tests: mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-llint Committed r248850: <https://trac.webkit.org/changeset/248850> Committed r248851: <https://trac.webkit.org/changeset/248851> Committed r248861: <https://trac.webkit.org/changeset/248861> |