Bug 200619

Summary: WebPage and ViewportConfiguration have differing notions of viewLayoutSize
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit2Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, simon.fraser, thorton, webkit-bug-importer, yongjun_zhang
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Wenson Hsieh
Reported 2019-08-10 19:26:32 PDT
m_viewLayoutSize exists in both WebPage and ViewportConfiguration. However, they mean different things (ViewportConfiguration’s m_viewLayoutSize is about the size of the platform view, and WebPage’s m_viewLayoutSize is about special the autosizing/autolayout mode on macOS that’s guarded by SPI). This makes some existing viewport configuration logic difficult to refactor and fix.
Attachments
Patch (21.75 KB, patch)
2019-08-10 21:48 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2019-08-10 21:48:01 PDT
Created attachment 376031 [details] Patch
Wenson Hsieh
Comment 2 2019-08-10 21:49:25 PDT
(This is motivated by the fix for <rdar://problem/52694257>).
WebKit Commit Bot
Comment 3 2019-08-11 12:12:04 PDT
Comment on attachment 376031 [details] Patch Clearing flags on attachment: 376031 Committed r248522: <https://trac.webkit.org/changeset/248522>
WebKit Commit Bot
Comment 4 2019-08-11 12:12:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.