Summary: | Web Inspector: RTL: DOM outline in Elements tab should be LTR | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||||||
Component: | Web Inspector | Assignee: | Nikita Vasilyev <nvasilyev> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, inspector-bugzilla-changes, timothy, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Nikita Vasilyev
2019-08-09 17:23:57 PDT
Created attachment 376551 [details]
Patch
Created attachment 376553 [details]
[Image] With patch applied
Comment on attachment 376551 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376551&action=review > Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js:47 > + this.element.dir = "ltr"; Set this in CSS instead? Comment on attachment 376551 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376551&action=review >> Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js:47 >> + this.element.dir = "ltr"; > > Set this in CSS instead? I set this as an attribute because there are CSS selectors that depend on it. For example, there's one that "unmirrors" disclosure triangles: body[dir=rtl] [dir=ltr] .tree-outline .item .disclosure-button { transform: unset; } Comment on attachment 376551 [details] Patch Clearing flags on attachment: 376551 Committed r248991: <https://trac.webkit.org/changeset/248991> All reviewed patches have been landed. Closing bug. |