Bug 200598

Summary: Web Inspector: Address some ESLint warnings
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix hi: review+

Joseph Pecoraro
Reported 2019-08-09 16:22:27 PDT
Address some ESLint warnings
Attachments
[PATCH] Proposed Fix (16.27 KB, patch)
2019-08-09 16:23 PDT, Joseph Pecoraro 		hi: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2019-08-09 16:23:38 PDT
Created attachment 375977 [details] [PATCH] Proposed Fix
Devin Rousso
Comment 2 2019-08-09 16:36:02 PDT
Comment on attachment 375977 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=375977&action=review r=me, awesome > Source/WebInspectorUI/UserInterface/Views/TreeOutline.js:734 > + // FIXME: Return values from this are crazy. I think this function can be removed entirely. Nobody seems to call it :P
Joseph Pecoraro
Comment 3 2019-08-12 11:48:35 PDT
> > Source/WebInspectorUI/UserInterface/Views/TreeOutline.js:734 > > + // FIXME: Return values from this are crazy. > > I think this function can be removed entirely. Nobody seems to call it :P Yep! Nice
Joseph Pecoraro
Comment 4 2019-08-12 11:49:26 PDT
https://trac.webkit.org/changeset/248537/webkit
Radar WebKit Bug Importer
Comment 5 2019-08-12 11:50:25 PDT
<rdar://problem/54219071>
Note You need to log in before you can comment on or make changes to this bug.