Bug 200595

Summary: Fix WebKitLegacy's post-process-header-rule script to support paths with spaces in them
Product: WebKit Reporter: Keith Rollin <krollin>
Component: WebKit Misc.Assignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bfulgham, commit-queue, darin, jbedard, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Keith Rollin
Reported 2019-08-09 15:44:02 PDT
A number of scripts were added to WebKit, JavaScriptCore, and WebKitLegacy to support XCBuild's new facility for copying and modifying files in one atomic step. The first two are OK, but WebKitLegacy's script (post-process-header-rule) references a file via a variable named "header", and does so without quoting the variable's value. When the header's path contains spaces -- as can happen when building Safari Technology Preview -- the script breaks. Fix this by adding quoting. Also fix a spot where post-process-header-rule expected that WebKitAvailability.h was referenced via a relative path for the form "./WebKitAvailability.h" rather than -- as is the case now -- an absolute path. <rdar://problem/54045608>
Attachments
Patch (2.51 KB, patch)
2019-08-09 15:46 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Rollin
Comment 1 2019-08-09 15:45:03 PDT
Ignore that comment about WebKitAvailability.h. I'll be taking care of that in another patch.
Keith Rollin
Comment 2 2019-08-09 15:46:41 PDT
Created attachment 375972 [details] Patch
WebKit Commit Bot
Comment 3 2019-08-09 16:52:20 PDT
Comment on attachment 375972 [details] Patch Clearing flags on attachment: 375972 Committed r248489: <https://trac.webkit.org/changeset/248489>
WebKit Commit Bot
Comment 4 2019-08-09 16:52:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.