| Summary: | [iOS 13] Google Docs/Slides/Sheets: paste often doesn't work and sometimes produces an error | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||
| Component: | HTML Editing | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bdakin, megan_gardner, rniwa, thorton, webkit-bug-importer, wenson_hsieh | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Wenson Hsieh
2019-08-09 14:32:48 PDT
Created attachment 375961 [details]
Patch
Comment on attachment 375961 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375961&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6826 > + switch (_focusedElementInformation.elementType) { > + case WebKit::InputType::Password: Either plain text field doesn't support pasting of an image, or all these could potentially support pasting of an image if we rely on page's scripts. r=me with this element type check removed as we discussed in person. Comment on attachment 375961 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375961&action=review >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6826 >> + case WebKit::InputType::Password: > > Either plain text field doesn't support pasting of an image, > or all these could potentially support pasting of an image if we rely on page's scripts. > > r=me with this element type check removed as we discussed in person. Thanks for the review! I’ll need to adjust this patch a little more after some feedback from UIKit folks (moving the SPI to the UITextInputPrivate protocol instead) Created attachment 375969 [details]
Patch
Landed <https://trac.webkit.org/r248487>. |