Summary: | [iOS WK2] Remove context menu hints on navigation | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, simon.fraser, thorton, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2019-08-09 14:07:04 PDT
Created attachment 375950 [details]
Patch
Comment on attachment 375950 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375950&action=review > Source/WebKit/ChangeLog:9 > + Make sure the context menu preview doesn't linger across navigations by hosting it in its hint! the preview is the platter that is presented above the context menu. > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3954 > + [self _hideContextMenu]; You don't hide the menu, just the hint > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6397 > + if (_contextMenuContainerView) { Ditto Created attachment 375956 [details]
Patch
Comment on attachment 375956 [details] Patch Clearing flags on attachment: 375956 Committed r248481: <https://trac.webkit.org/changeset/248481> Comment on attachment 375956 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375956&action=review > Source/WebKit/ChangeLog:15 > + (-[WKContentView _didCommitLoadForMainFrame]): The issue will still be happening for subframe navigations, correct? Yes, but we can fix that separately. |