| Summary: | Web Inspector: REGRESSION(r248454): WK1 inspector frontend client doesn't queue messages to the frontend before it's loaded | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, rniwa, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=200110 | ||||||||||||
| Bug Depends on: | 200109 | ||||||||||||
| Bug Blocks: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Devin Rousso
2019-08-09 14:05:52 PDT
Created attachment 375954 [details]
Patch
I think this might also fix the test failures for <https://webkit.org/b/200110>. Comment on attachment 375954 [details]
Patch
r=me assuming tests pass!
Comment on attachment 375954 [details] Patch Attachment 375954 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12887347 New failing tests: inspector/debugger/break-in-constructor-before-super.html inspector/debugger/breakpoint-eval-with-exception.html inspector/debugger/setBreakpointByUrl-sourceURL.html inspector/debugger/evaluateOnCallFrame-errors.html inspector/debugger/pause-on-assert.html inspector/debugger/setBreakpoint-condition.html inspector/debugger/regress-133182.html inspector/debugger/setBreakpoint-column.html Created attachment 375967 [details]
Archive of layout-test-results from ews103 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 375954 [details] Patch Attachment 375954 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12887581 New failing tests: inspector/debugger/breakpoint-eval-with-exception.html inspector/debugger/setBreakpointByUrl-sourceURL.html inspector/debugger/evaluateOnCallFrame-errors.html inspector/debugger/pause-on-assert.html inspector/debugger/setBreakpoint-condition.html inspector/debugger/regress-133182.html inspector/debugger/setBreakpoint-column.html Created attachment 375979 [details]
Archive of layout-test-results from ews114 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 375996 [details]
Patch
Add additional code which I mistakenly forgot to copy from `doDispatchMessageOnFrontendPage`
Comment on attachment 375996 [details] Patch Clearing flags on attachment: 375996 Committed r248497: <https://trac.webkit.org/changeset/248497> All reviewed patches have been landed. Closing bug. |