Summary: | Can’t sort videos on a YouTube channel page on iPad | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||
Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | andersca, commit-queue, darin, ews-watchlist, ggaren | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Antti Koivisto
2019-08-09 07:02:40 PDT
Created attachment 375916 [details]
patch
Attachment 375916 [details] did not pass style-queue:
ERROR: Source/WebCore/page/Quirks.cpp:351: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/page/Quirks.cpp:351: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 2 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 375919 [details]
patch
Comment on attachment 375919 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=375919&action=review > Source/WebCore/ChangeLog:9 > + Add a quick to make touch events non-cancelable (preventDefault() does nothing. Typo, quick. Comment on attachment 375919 [details]
patch
I don’t see the code calling the new function.
Comment on attachment 375919 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=375919&action=review r=me >> Source/WebCore/ChangeLog:9 >> + Add a quick to make touch events non-cancelable (preventDefault() does nothing. > > Typo, quick. As long as we're piling on tyops, let's put a ) at the end of the sentence :P. Comment on attachment 375919 [details]
patch
Oh yeah, Darin has a point: We should probably call this function.
Theres is an internal patch that calls the function. Created attachment 376003 [details]
patch
Comment on attachment 376003 [details] patch Clearing flags on attachment: 376003 Committed r248499: <https://trac.webkit.org/changeset/248499> All reviewed patches have been landed. Closing bug. |