Summary: | [XBL] XBLCachedDocument cleanup | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Julien Chaffraix <jchaffraix> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Julien Chaffraix
2008-07-16 09:48:08 PDT
Created attachment 22309 [details]
Proposed cleanup
Comment on attachment 22309 [details]
Proposed cleanup
I think:
5 RefPtr<WebCore::XBLDocument> document() const { return m_document; }
Should probably return PassRefPtr, no? PassRefPtr will automatically copy from RefPtr in this case, but there will be no additional ref churn on assignment. Otherwise looks fine.
> Should probably return PassRefPtr, no? PassRefPtr will automatically copy from
> RefPtr in this case, but there will be no additional ref churn on assignment.
I think so too so I switched to PassRefPtr before landing.
|