Bug 20056

Summary: [XBL] XBLCachedDocument cleanup
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed cleanup eric: review+

Description Julien Chaffraix 2008-07-16 09:48:08 PDT
The current version uses old APIs (some of them removed). It has also some coding style violations.
Comment 1 Julien Chaffraix 2008-07-16 09:51:07 PDT
Created attachment 22309 [details]
Proposed cleanup
Comment 2 Eric Seidel (no email) 2008-07-22 08:37:20 PDT
Comment on attachment 22309 [details]
Proposed cleanup

I think:
5         RefPtr<WebCore::XBLDocument> document() const { return m_document; }

Should probably return PassRefPtr, no?  PassRefPtr will automatically copy from RefPtr in this case, but there will be no additional ref churn on assignment.  Otherwise looks fine.
Comment 3 Julien Chaffraix 2008-07-23 13:27:00 PDT
Committed in r35299.
Comment 4 Julien Chaffraix 2008-07-23 13:28:31 PDT
> Should probably return PassRefPtr, no?  PassRefPtr will automatically copy from
> RefPtr in this case, but there will be no additional ref churn on assignment. 

I think so too so I switched to PassRefPtr before landing.