Bug 200555

Summary: Web Inspector: Elements: Computed: move the Box Model section to the top
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=200724
https://bugs.webkit.org/show_bug.cgi?id=200725
Attachments:
Description Flags
Patch
joepeck: review+
[Image] After Patch is applied
none
Patch
hi: commit-queue+
Patch none

Devin Rousso
Reported 2019-08-08 17:46:14 PDT
For nodes that set a LOT of CSS properties, having the Box Model section waaay at the bottom may not be as useful for a quick glance. Bringing it to the top makes it much more visible, and it's still collapsable if the developer doesn't actually want to see it at all.
Attachments
Patch (7.91 KB, patch)
2019-08-08 17:59 PDT, Devin Rousso 		joepeck: review+
DetailsFormatted DiffDiff
[Image] After Patch is applied (144.10 KB, image/png)
2019-08-08 18:00 PDT, Devin Rousso 		no flags
Details
Patch (2.54 KB, patch)
2019-08-14 10:37 PDT, Devin Rousso 		hi: commit-queue+
DetailsFormatted DiffDiff
Patch (2.54 KB, patch)
2019-08-14 10:43 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-08-08 17:59:37 PDT
Created attachment 375873 [details] Patch
Devin Rousso
Comment 2 2019-08-08 18:00:10 PDT
Created attachment 375874 [details] [Image] After Patch is applied The colors are the same as they were previously in Dark mode.
Joseph Pecoraro
Comment 3 2019-08-14 10:08:00 PDT
Comment on attachment 375873 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375873&action=review This may make sense given it is a fixed size. I think we can give it a shot. r=me > Source/WebInspectorUI/ChangeLog:14 > + Drive-by: use a different identifier string for the Variable section so it preserves its own > + collapsed state independent of the Properties section. All of these drive-bys could have been its own bug.
Devin Rousso
Comment 4 2019-08-14 10:14:50 PDT
Comment on attachment 375873 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375873&action=review >> Source/WebInspectorUI/ChangeLog:14 >> + collapsed state independent of the Properties section. > > All of these drive-bys could have been its own bug. True... I'll create separate bugs for each :)
Devin Rousso
Comment 5 2019-08-14 10:37:46 PDT
Created attachment 376279 [details] Patch
Devin Rousso
Comment 6 2019-08-14 10:43:04 PDT
Created attachment 376282 [details] Patch Oops. That's what I get for trying to manually edit a diff 🤦‍♂️
WebKit Commit Bot
Comment 7 2019-08-14 11:45:11 PDT
Comment on attachment 376282 [details] Patch Clearing flags on attachment: 376282 Committed r248683: <https://trac.webkit.org/changeset/248683>
WebKit Commit Bot
Comment 8 2019-08-14 11:45:12 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-08-14 11:46:22 PDT
<rdar://problem/54312008>
Blaze Burg
Comment 10 2019-08-14 12:35:29 PDT
LGTM.
Note You need to log in before you can comment on or make changes to this bug.