Summary: | Web Inspector: Elements: Computed: move the Box Model section to the top | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | bburg, commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=200724 https://bugs.webkit.org/show_bug.cgi?id=200725 |
||||||||||||
Attachments: |
|
Description
Devin Rousso
2019-08-08 17:46:14 PDT
Created attachment 375873 [details]
Patch
Created attachment 375874 [details]
[Image] After Patch is applied
The colors are the same as they were previously in Dark mode.
Comment on attachment 375873 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375873&action=review This may make sense given it is a fixed size. I think we can give it a shot. r=me > Source/WebInspectorUI/ChangeLog:14 > + Drive-by: use a different identifier string for the Variable section so it preserves its own > + collapsed state independent of the Properties section. All of these drive-bys could have been its own bug. Comment on attachment 375873 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375873&action=review >> Source/WebInspectorUI/ChangeLog:14 >> + collapsed state independent of the Properties section. > > All of these drive-bys could have been its own bug. True... I'll create separate bugs for each :) Created attachment 376279 [details]
Patch
Created attachment 376282 [details]
Patch
Oops. That's what I get for trying to manually edit a diff 🤦♂️
Comment on attachment 376282 [details] Patch Clearing flags on attachment: 376282 Committed r248683: <https://trac.webkit.org/changeset/248683> All reviewed patches have been landed. Closing bug. LGTM. |