Summary: | Add a test to ensure that we dispatch keydown and keyup events when multiple keys are pressed at the same time | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||
Component: | Tools / Tests | Assignee: | Daniel Bates <dbates> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | darin, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Local Build | ||||||
Hardware: | iPhone / iPad | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Daniel Bates
2019-08-08 15:10:24 PDT
Created attachment 375844 [details]
Patch
Comment on attachment 375844 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375844&action=review > LayoutTests/platform/ios/TestExpectations:3361 > +# Skip until we have the fixes for <rdar://problem/53613454> and <rdar://problem/54001139>. > +fast/events/ios/multiple-key-press-and-release-ordering.html [ Skip ] Why not expect a failure instead of skipping? Because its failure mode is a time out 😀. I had two options because of that: 1. Make test wait minimum amount of time before declaring failure 2. Mark the test as timeout in expectations Both options have disadvantages though I was really leaning towards (2) because it's not extra work for me. I chose not to do (2) because someone once told me not to because "machines have limited resources" reasons. Not sure if that is true anymore.😕 Skip seems fine for a timeout that will be fixed soon. Comment on attachment 375844 [details] Patch Clearing flags on attachment: 375844 Committed r248531: <https://trac.webkit.org/changeset/248531> All reviewed patches have been landed. Closing bug. |