| Summary: | Move classes declared inside StorageManager.cpp into their own headers | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
| Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, beidson, cgarcia, commit-queue, ews-watchlist, ggaren, sihui_liu, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Chris Dumez
2019-08-07 19:18:32 PDT
Created attachment 375777 [details]
Patch
Comment on attachment 375777 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375777&action=review > Source/WebKit/NetworkProcess/WebStorage/LocalStorageNamespace.cpp:37 > +// FIXME: The quota value is copied from GroupSettings.cpp. I'm not sure this comment is current. This file doesn't exist any more. > Source/WebKit/NetworkProcess/WebStorage/StorageArea.cpp:40 > + : m_localStorageNamespace(localStorageNamespace ? makeWeakPtr(*localStorageNamespace) : nullptr) Can't we just use the makeWeakPtr overload that takes a pointer now? > Source/WebKit/NetworkProcess/WebStorage/TransientLocalStorageNamespace.h:55 > + const unsigned m_quotaInBytes; There are many of these that don't have default initializers in the headers. It might be worth adding some. Created attachment 375806 [details]
Patch
Comment on attachment 375806 [details] Patch Clearing flags on attachment: 375806 Committed r248422: <https://trac.webkit.org/changeset/248422> All reviewed patches have been landed. Closing bug. |