Bug 200525

Summary: [WHLSL] Trivial clean-up of the MSL code generated
Product: WebKit Reporter: Robin Morisset <rmorisset>
Component: WebGPUAssignee: Robin Morisset <rmorisset>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, ews-watchlist, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=200961
Attachments:
Description Flags
Patch
darin: review+
Patch for landing none

Robin Morisset
Reported 2019-08-07 17:39:41 PDT
We emit some redundant '{}' around function bodies (we emit them both when visiting the function definition itself and the block). We also emit some branch for ternary expressions instead of just using a ternary.
Attachments
Patch (2.79 KB, patch)
2019-08-07 17:42 PDT, Robin Morisset 		darin: review+
DetailsFormatted DiffDiff
Patch for landing (2.78 KB, patch)
2019-08-13 11:50 PDT, Robin Morisset 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Robin Morisset
Comment 1 2019-08-07 17:42:55 PDT
Created attachment 375771 [details] Patch
Darin Adler
Comment 2 2019-08-09 09:59:43 PDT
Comment on attachment 375771 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375771&action=review > Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.cpp:253 > + m_stringBuilder.append("\n"); I think that appending a single character is slightly more efficient if you use the character: append('\n')
Robin Morisset
Comment 3 2019-08-13 11:50:29 PDT
Created attachment 376190 [details] Patch for landing
WebKit Commit Bot
Comment 4 2019-08-15 10:49:45 PDT
Comment on attachment 376190 [details] Patch for landing Clearing flags on attachment: 376190 Committed r248729: <https://trac.webkit.org/changeset/248729>
WebKit Commit Bot
Comment 5 2019-08-15 10:49:46 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-08-15 10:50:22 PDT
<rdar://problem/54353040>
Robin Morisset
Comment 7 2019-08-21 10:46:13 PDT
The ternary part of this patch was just wrong because of effects. See https://bugs.webkit.org/show_bug.cgi?id=200961
Note You need to log in before you can comment on or make changes to this bug.