Bug 200514

Summary: Remove speculative workaround for upload crash
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, ggaren, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
commit-queue: commit-queue-
patch none

Alex Christensen
Reported 2019-08-07 12:42:51 PDT
Remove speculative workaround for upload crash
Attachments
Patch (1.70 KB, patch)
2019-08-07 12:43 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (1.70 KB, patch)
2019-08-07 13:05 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (1.70 KB, patch)
2019-08-07 13:05 PDT, Alex Christensen 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
patch (1.70 KB, patch)
2019-08-07 13:57 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-08-07 12:43:26 PDT
Created attachment 375733 [details] Patch
John Wilander
Comment 2 2019-08-07 13:02:45 PDT
Build failures on both Mac and iOS bots looks like a real issue. Other than that, the patch looks good to me.
Alex Christensen
Comment 3 2019-08-07 13:05:08 PDT
Created attachment 375739 [details] Patch
Alex Christensen
Comment 4 2019-08-07 13:05:17 PDT
Created attachment 375741 [details] Patch
John Wilander
Comment 5 2019-08-07 13:07:39 PDT
Someone is going to complain that I'm not a reviewer. :) Someone needs to nominate me, I think.
WebKit Commit Bot
Comment 6 2019-08-07 13:33:16 PDT
Comment on attachment 375741 [details] Patch Rejecting attachment 375741 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 375741, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit John Wilander found in /Volumes/Data/EWS/WebKit/Source/WebKit/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/EWS/WebKit/Source/WebKit/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: https://webkit-queues.webkit.org/results/12875172
Alex Christensen
Comment 7 2019-08-07 13:57:10 PDT
Created attachment 375749 [details] patch
Geoffrey Garen
Comment 8 2019-08-07 13:59:13 PDT
Comment on attachment 375749 [details] patch r=me
WebKit Commit Bot
Comment 9 2019-08-07 16:36:33 PDT
Comment on attachment 375749 [details] patch Clearing flags on attachment: 375749 Committed r248394: <https://trac.webkit.org/changeset/248394>
WebKit Commit Bot
Comment 10 2019-08-07 16:36:35 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2019-08-07 16:37:56 PDT
<rdar://problem/54056423>
Note You need to log in before you can comment on or make changes to this bug.