Summary: | SVGAnimated* properties macro magic needs to be rewritten | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> | ||||||||||
Component: | SVG | Assignee: | Nikolas Zimmermann <zimmermann> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | achristensen, eric, koivisto, oliver, rindahl, sabouhallawa | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Mac | ||||||||||||
OS: | OS X 10.5 | ||||||||||||
Bug Depends on: | 10745, 20052 | ||||||||||||
Bug Blocks: | 12171 | ||||||||||||
Attachments: |
|
Description
Nikolas Zimmermann
2008-07-16 05:15:30 PDT
Created attachment 22325 [details]
Initial patch
Forgot to mention in the bug description, that SVG<->XML synchronization shouldn't need any callbacks. This patch also fixes that.
Created attachment 22343 [details]
Updated patch
Slightly changed patch, let updateAnimated* take const String& instead of StringImpl, refactor synchronization code in helper function (used by SVGPolyElement in a follow-up patch)
Comment on attachment 22343 [details]
Updated patch
Okay, afaict this looks sane, but i'd like antti to look at it at some point. r=me
Reopening to attach new patch. Created attachment 375744 [details]
Patch
Created attachment 375745 [details]
Patch
(In reply to Alex Christensen from comment #7) > Created attachment 375745 [details] > Patch I think this patch should be uploaded to https://bugs.webkit.org/show_bug.cgi?id=200514. |